Skip to content
Snippets Groups Projects

Adding a new cond alg for MMG

Merged Adding a new cond alg for MMG
mvozak/athena:newMuMMGCondAlg into 24.0
All threads resolved!
Merged Matous Vozak requested to merge mvozak/athena:newMuMMGCondAlg into 24.0
All threads resolved!

This is an implementation of the condition alg and database for the MMG incorporating effective drift velocity and calibration

@pscholer @jojungge @kluit @stavrop

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Matous Vozak added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondAlg
    • MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondData

    Affected files list will not be printed in this case

    Adding @stavrop ,@pscholer ,@apsallid ,@jojungge ,@mvozak ,@kluit as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 66048f4f)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 10a8c7da)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Johannes Junggeburth resolved all threads

    resolved all threads

  • Matous Vozak marked this merge request as draft

    marked this merge request as draft

  • Matous Vozak changed title from adding a new cond alg for MMG to Draft:Adding a new cond alg for MMG

    changed title from adding a new cond alg for MMG to Draft:Adding a new cond alg for MMG

  • Lukas Kretschmann
    Lukas Kretschmann @lkretsch ·
    Developer

    Removing review label since marked as draft. -L1

  • Lukas Kretschmann removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Matous Vozak added 1 commit

    added 1 commit

    • 0d474914 - fix retrieval from database, adding conf for the new cond alg

    Compare with previous version

  • Matous Vozak marked this merge request as ready

    marked this merge request as ready

  • Matous Vozak added review-pending-level-1 label

    added review-pending-level-1 label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondAlg
    • MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondData
    • MuonSpectrometer/MuonConfig

    Affected files list will not be printed in this case

    Adding @jojungge ,@kluit ,@stavrop ,@apsallid ,@pscholer ,@mvozak as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 0d474914)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Lukas Kretschmann
  • Lukas Kretschmann
    Lukas Kretschmann @lkretsch ·
    Developer

    Looks good to me, just one old code snippet commented. -L1

  • Lukas Kretschmann added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Matous Vozak resolved all threads

    resolved all threads

  • Matous Vozak added 1 commit

    added 1 commit

    • da4e1c88 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Matous Vozak resolved all threads

    resolved all threads

  • Matous Vozak removed review-user-action-required label

    removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: Build area was cleaned as per request posted in the DB. The full software build will be performed

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondAlg
    • MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondData
    • MuonSpectrometer/MuonConfig

    Affected files list will not be printed in this case

    Adding @stavrop ,@jojungge ,@apsallid ,@mvozak ,@kluit ,@pscholer as watchers

  • ATLAS Robot added review-pending-level-1 label

    added review-pending-level-1 label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash da4e1c88)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Matous Vozak
    Matous Vozak @mvozak ·
    Author Developer

    Hi @lkretsch,

    thank you for the review, if possible can we approve and merge this before the end of today? It is an initial MR for some follow ups that we would like to have for the upcoming 2024 reprocessing.

    Thank you in advance, Mat

  • Matous Vozak removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Matous Vozak
    Matous Vozak @mvozak ·
    Author Developer

    Given there was just a comment on the commented line to be removed and the L1 was already approved before that I hope it is not controversial to remove the L1 label.

  • Johannes Junggeburth added review-approved label

    added review-approved label

  • Johannes Junggeburth
    Johannes Junggeburth @jojungge ·
    Developer

    Approving as domain expert

  • Jean-Baptiste De Vivie De Regie added review-approved-tier0 label

    added review-approved-tier0 label

  • Jean-Baptiste De Vivie De Regie mentioned in commit bcea9e0c

    mentioned in commit bcea9e0c

  • Jean-Baptiste De Vivie De Regie merged

    merged

  • Frank Winklmeier mentioned in merge request !78596 (merged)

    mentioned in merge request !78596 (merged)

  • Matous Vozak mentioned in merge request !78615 (merged)

    mentioned in merge request !78615 (merged)

    • Please register or sign in to reply