Skip to content
Snippets Groups Projects

non-templated base class for seeding tools, added useML check to Gbts2Acts tool, EFTRACK-142

Merged non-templated base class for seeding tools, added useML check to Gbts2Acts tool, EFTRACK-142
demelian/athena:trig-ftf-gbts-refactor into main
All threads resolved!
Merged Dmitry Emeliyanov requested to merge demelian/athena:trig-ftf-gbts-refactor into main
All threads resolved!

removed unneeded templating of GBTS classes, using spacepoint indices instead of pointers, added check if useML is true to Gbts2Acts seeding tool, EFTRACK-142

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Trigger/TrigTools/TrigInDetPattRecoTools

    This merge request affects 15 files:

    • Trigger/TrigTools/TrigInDetPattRecoTools/CMakeLists.txt
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/GNN_DataStorage.cxx
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/GNN_DataStorage.h
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/GNN_DataStorage.ipp
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/GNN_TrackingFilter.cxx
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/GNN_TrackingFilter.h
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/GNN_TrackingFilter.ipp
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/Gbts2ActsSeedingTool.cxx
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/Gbts2ActsSeedingTool.h
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/SeedingToolBase.cxx
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/SeedingToolBase.h
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/SeedingToolBase.ipp
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/TrigInDetTrackSeedingTool.cxx
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/TrigInDetTrackSeedingTool.h
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/components/TrigInDetTrackSeedingTools_entries.cxx

    Adding @pagessin ,@sutt ,@tbold ,@toyamaza ,@keli ,@cvarni ,@nagano ,@jojungge ,@bkerridg as watchers

  • ATLAS Robot added ACTS Trigger TriggerID main review-pending-level-1 labels

    added ACTS Trigger TriggerID main review-pending-level-1 labels

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash c53937f7)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Tim Adye
  • Dmitry Emeliyanov resolved all threads

    resolved all threads

  • Lukas Kretschmann added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Tim Adye resolved all threads

    resolved all threads

  • Tim Adye
  • Tim Adye
  • Tim Adye
  • Tim Adye
  • Dmitry Emeliyanov added 1 commit

    added 1 commit

    • 3e733f81 - addressing comments on MR78555

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Trigger/TrigTools/TrigInDetPattRecoTools

    This merge request affects 15 files:

    • Trigger/TrigTools/TrigInDetPattRecoTools/CMakeLists.txt
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/GNN_DataStorage.cxx
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/GNN_DataStorage.h
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/GNN_DataStorage.ipp
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/GNN_TrackingFilter.cxx
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/GNN_TrackingFilter.h
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/GNN_TrackingFilter.ipp
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/Gbts2ActsSeedingTool.cxx
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/Gbts2ActsSeedingTool.h
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/SeedingToolBase.cxx
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/SeedingToolBase.h
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/SeedingToolBase.ipp
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/TrigInDetTrackSeedingTool.cxx
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/TrigInDetTrackSeedingTool.h
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/components/TrigInDetTrackSeedingTools_entries.cxx

    Adding @sutt ,@tbold ,@nagano ,@pagessin ,@keli ,@toyamaza ,@bkerridg ,@jojungge ,@cvarni as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • Dmitry Emeliyanov resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 3e733f81)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Tim Adye
  • Dmitry Emeliyanov resolved all threads

    resolved all threads

  • Dmitry Emeliyanov added 1 commit

    added 1 commit

    • 5e278f5f - using the initialization value in the variable definition

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Trigger/TrigTools/TrigInDetPattRecoTools

    This merge request affects 15 files:

    • Trigger/TrigTools/TrigInDetPattRecoTools/CMakeLists.txt
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/GNN_DataStorage.cxx
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/GNN_DataStorage.h
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/GNN_DataStorage.ipp
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/GNN_TrackingFilter.cxx
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/GNN_TrackingFilter.h
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/GNN_TrackingFilter.ipp
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/Gbts2ActsSeedingTool.cxx
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/Gbts2ActsSeedingTool.h
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/SeedingToolBase.cxx
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/SeedingToolBase.h
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/SeedingToolBase.ipp
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/TrigInDetTrackSeedingTool.cxx
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/TrigInDetTrackSeedingTool.h
    • Trigger/TrigTools/TrigInDetPattRecoTools/src/components/TrigInDetTrackSeedingTools_entries.cxx

    Adding @bkerridg ,@toyamaza ,@keli ,@cvarni ,@pagessin ,@tbold ,@nagano ,@jojungge ,@sutt as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 5e278f5f)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Lukas Kretschmann
    Lukas Kretschmann @lkretsch ·
    Developer

    Changes are fine and CI succeeds, approving for L1. -L1

  • Lukas Kretschmann added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Frank Winklmeier merged

    merged

  • Frank Winklmeier mentioned in commit ba515b17

    mentioned in commit ba515b17

    • Please register or sign in to reply