Skip to content
Snippets Groups Projects

IsolationSelection: Move setting of isLRT decoration to merge algorithms.

Merged Scott Snyder requested to merge ssnyder/athena:lrtDecor.IsolationSelection-20250314 into main
All threads resolved!

Instead, rely on it being set by the LRT merge algorithms. This avoids issues with multiple algorithms trying to set the same decoration. Also, when this algorithm was being run on the output of the LRT merge algorithms, the decoration was being set incorrectly.

For the LRT merge algorithms, use decoration handles so that the decorations get locked.

Merge request reports

Pipeline #11038796 passed

Pipeline passed for 2624623f on ssnyder:lrtDecor.IsolationSelection-20250314

Approval is optional

Merged by Frank WinklmeierFrank Winklmeier 1 month ago (Mar 18, 2025 8:56am UTC)

Merge details

  • Changes merged into main with 71de1769 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Scott Snyder added 1 commit

    added 1 commit

    • 2624623f - Make decorator objects static const

    Compare with previous version

  • This merge request affects 3 packages:

    • PhysicsAnalysis/Algorithms/EgammaAnalysisAlgorithms
    • PhysicsAnalysis/Algorithms/MuonAnalysisAlgorithms
    • PhysicsAnalysis/AnalysisCommon/IsolationSelection

    Affected files list will not be printed in this case

    Adding @falonso ,@sangelid ,@krumnack ,@sfrances ,@tadej ,@lucam ,@nicolaid ,@oducu ,@apsallid as watchers

  • :white_check_mark: CI Result SUCCESS (hash 2624623f)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Lukas Kretschmann resolved all threads

    resolved all threads

  • Changes are fine and CI succeeds, approving for L1. -L1

  • Purely technical update, approving for AR.

    Nils [Analysis RC]

  • mentioned in commit 71de1769

  • Please register or sign in to reply
    Loading