Skip to content
Snippets Groups Projects

add columnar tool wrapper and in-memory test fixture (ATLASG-2853)

Merged Nils Erik Krumnack requested to merge krumnack/athena:tool_wrapper into main
All threads resolved!

The tool wrappers are also shared with the python tool wrappers and the PHYSLITE test fixture (both to come in future commits). The in-memory test is the basic test fixture for columnar tools to check that they work in columnar mode.

Merge request reports

Pipeline #11123557 passed

Pipeline passed for 33a8ae9c on krumnack:tool_wrapper

Approval is optional

Merged by Vakhtang TsulaiaVakhtang Tsulaia 12 hours ago (Mar 26, 2025 4:34pm UTC)

Merge details

  • Changes merged into main with 0c60f902 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 33a8ae9c - remove ATLAS_NO_CHECK_FILE_THREAD_SAFETY from test

    Compare with previous version

  • Nils Erik Krumnack resolved all threads

    resolved all threads

  • This merge request affects 4 packages:

    • PhysicsAnalysis/Columnar/ColumnarExampleTools
    • PhysicsAnalysis/Columnar/ColumnarInterfaces
    • PhysicsAnalysis/Columnar/ColumnarTestFixtures
    • PhysicsAnalysis/Columnar/ColumnarToolWrapper

    Affected files list will not be printed in this case

  • :white_check_mark: CI Result SUCCESS (hash 33a8ae9c)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Karolos Potamianos resolved all threads

    resolved all threads

  • Looks good. Karolos (L2)

  • Normally I don't approve my own MRs, but this was previously agreed on, and there is no one else available to sign off for AR.

    Nils [Analysis RC]

  • mentioned in commit 0c60f902

  • Please register or sign in to reply
    Loading