not reorder json key in BTagging tools

Observed by @caiyi the changing of sequence of the pT_key in JSON, this MR intends to fix by loading the JSON with nlohmann::ordered_json instead of nlohmann::json

cc @ligang @robouque

This merge request affects 1 package:

• PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/xAODBTaggingEfficiency

This merge request affects 2 files:

• PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/xAODBTaggingEfficiency/xAODBTaggingEfficiency/BTaggingEfficiencyJsonTool.h
• PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/xAODBTaggingEfficiency/xAODBTaggingEfficiency/BTaggingSelectionJsonTool.h

Adding @dguest ,@ligang ,@svanstro ,@robouque ,@bdong ,@lidiaz as watchers

added BTagging Derivation JetEtmiss analysis-review-required main review-pending-level-1 labels

changed the description

It worries me if the ordering of keys in a json dict is required for correct behavior. This isn't something required by the json spec, meaning any tools that rely on it have to have specific extensions.

So I guess this is fine as a quick fix, but we should probably rewrite our file format so this isn't a requirement.

Another stable solution is to create another string vector m_pTkeys from the double vector m_pTbins without changing the input json file, like below

200 -> pT_200_250
250 -> pT_250_300
...

CI Result SUCCESS (hash 45b89a47)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

Hi @bdong ! There's an unresolved thread. Is it to be followed or can be already closed? Thanks, L1 (Fábio).

removed review-pending-level-1 label

resolved all threads

added review-user-action-required label

removed review-user-action-required label

added review-pending-level-1 label

resolved all threads

All threads resolved and CI succeeded. Approving from L1 side (Fábio).

removed review-pending-level-1 label

added review-approved label

added analysis-review-approved label and removed analysis-review-required label

mentioned in commit 4cb70cd2

merged

mentioned in merge request !78611 (merged)

mentioned in commit 663f4344

mentioned in commit ea3a3fbc