TrigNSWSimulation tools revert main merge from 2025-03-15

!78514 (merged) needs to be ported manually to main without any useage of AGDD. That broke the developments of the Phase-II L0.

Tagging: @fgravili, @jchapman, @jcatmore, @lmonaco, @markowen

added bugfix urgent labels

This merge request affects 1 package:

• Trigger/TrigT1/TrigT1NSWSimTools

This merge request affects 10 files:

• Trigger/TrigT1/TrigT1NSWSimTools/CMakeLists.txt
• Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/MMLoadVariables.h
• Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/MMT_Diamond.h
• Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/MMT_Hit.h
• Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/MMT_struct.h
• Trigger/TrigT1/TrigT1NSWSimTools/src/MMLoadVariables.cxx
• Trigger/TrigT1/TrigT1NSWSimTools/src/MMT_Diamond.cxx
• Trigger/TrigT1/TrigT1NSWSimTools/src/MMT_Hit.cxx
• Trigger/TrigT1/TrigT1NSWSimTools/src/MMT_struct.cxx
• Trigger/TrigT1/TrigT1NSWSimTools/src/MMTriggerTool.cxx

added Trigger main review-pending-level-1 labels

changed the description

removed Trigger main review-pending-level-1 labels

added Trigger main review-pending-level-1 labels

mentioned in merge request !78560 (merged)

Hi @jojungge , I was working privately on that... I need just an information: is there another way to retrieve the distanceFromZAxis quantity https://gitlab.cern.ch/atlas/athena/-/blob/24.0/Trigger/TrigT1/TrigT1NSWSimTools/src/MMT_Hit.cxx?ref_type=heads#L97 ? If so (I didn't find an obvious method other that that), I can remove any instance of AGDD package(s)

Hello @fgravili , yes you can retrieve it like this:

const MuonGM::MMReadoutElement* readout = detManager->getMMReadoutElement(strip_id); const double distanceFromZAxis = readout->absTransform().translation().perp() - 0.5*readout->getRsize();

This should provide the same result. You can check here:

https://gitlab.cern.ch/atlas/athena/-/blob/acae2be6e58f0247d2e0dc90121805a37a0227e4/Trigger/TrigT1/TrigT1NSWSimTools/src/MMT_Hit.cxx

just check how it's solved in main

CI Result SUCCESS (hash 023408db)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

Thanks a lot! I wasn't aware of the different implementation in main

Changes are fine and CI succeeds, approving for L1. -L1

added review-approved label and removed review-pending-level-1 label

mentioned in merge request !78604 (merged)

mentioned in commit 49cd5431

merged

mentioned in merge request !78650 (merged)