main-bugfix-PixelDigitization

Alter upper limit for ToT generation in case of the ITk pixel chip. This was previously set to 16, should be 14. Closes ATLITKSW-301.

This merge request affects 1 package:

• InnerDetector/InDetDigitization/PixelDigitization

This merge request affects 3 files:

• InnerDetector/InDetDigitization/PixelDigitization/src/PixelNoiseFunctions.cxx
• InnerDetector/InDetDigitization/PixelDigitization/src/PixelNoiseFunctions.h
• InnerDetector/InDetDigitization/PixelDigitization/src/RD53SimTool.cxx

Adding @goetz ,@stsuno ,@sroe ,@battagl ,@lshan ,@jchapman as watchers

added Digitization InnerDetector main review-pending-level-1 labels

changed the description

added bugfix label

added Run4-PileUpPresampling-output-changed label

CI Result FAILURE (hash 7854c7e7)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

Fails a Run4 test, which is expected.

The reference file in this case is /cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/WorkflowReferences/main/d1920/v7/myRDO.pool.root.

Who can update this? @jchapman ?

In fact, I might have expected more tests to fail Having instrumented the digital and checked, seems ok.

ERROR    Your change breaks the frozen tier0 policy in test d1920.
ERROR    Please make sure this has been discussed in the correct meeting (RIG or Simulation) meeting and approved by the relevant experts.
ERROR    Copied '/build/ci-builds/main/Athena/build/Athena/AtlasTest/CITest/CMakeFiles/ciTestRun/PileUpPresamplingRun4FullTruth/run_d1920/myRDO.pool.root' to '/eos/atlas/atlascerngroupdisk/proj-ascig/gitlabci/MR78606_7854c7e7869e43f53cfcc0af23fb57ec16c98aaf/PileUpPresamplingRun4FullTruth'

mentioned in merge request !77406

added review-user-action-required label and removed review-pending-level-1 label

added RC Attention Required label

Need offline-sw-review-approved from @jmasik for reference update.

I was not aware that Run 4 pileup digitization in main was under frozen T0 policy. The output change is expected and intended.

Tommaso

added offline-sw-review-approved label

removed review-user-action-required label

added review-pending-level-1 label

resolved all threads

removed review-pending-level-1 label

@fwinkl Do I need to do something more to move this forward?

resolved all threads

added 126 commits

• 7854c7e7...20b2cf62 - 124 commits from branch atlas:main
• cf13273d - alter limit for ToT generation
• e9737d0c - Update CI references

Compare with previous version

This merge request affects 2 packages:

• InnerDetector/InDetDigitization/PixelDigitization
• Tools/WorkflowTestRunner

Affected files list will not be printed in this case

Adding @battagl ,@lshan ,@stsuno ,@goetz ,@jchapman ,@pagessin ,@sroe as watchers

added Tools review-pending-level-1 labels

CI Result SUCCESS (hash e9737d0c)

	Athena	AthSimulation	AthGeneration
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

merged

mentioned in commit 543e43af

added ITk label