Skip to content

Draft: ActsObjectDecoration: Use SiHit and SDO unique IDs rather than barcodes

John Derek Chapman requested to merge jchapman/athena:ActsObjectDecoration_uniqueID_main into main

This is part of the migration away from HepMC::barcodes in main. The SiHit and InDetSimData (SDO) classes fully support using GenParticle::id() rather than the deprecated barcode variable from HepMC2. This merge request migrates the internal logic of the code in ActsObjectDecoration to use unique IDs, but I've left it as draft as any clients of the decorations added would also need to be migrated to use uniqueIDs. Currently I've left the decoration names unchanged, but the saved are no longer barcodes. Other options would be to apply both barcode and uniqueID decorations temporarily or to change the decoration names to be uniqueID. NB If the decorations are used to compare to xAOD::TruthParticles then the decorations would need to continue to store barcodes until !76135 is merged. In which case, we can migrate the internal logic to use uniqueIDs, but still store barcodes as a halfway measure and push the rest of the changes into !76135.

Tagging @cvarni to comment on where these decorations are used.

Merge request reports