Added ACTS cluster postInclude

To be considered for common definition of tracking technical efficiency. To be configured with

--postInclude "ActsConfig.ActsPostIncludes.ACTSClusterPostInclude" --preExec "flags.Tracking.writeExtendedSi_PRDInfo=True"

Checked to produce the expected outcome when running for instance in parallel with the legacy reconstruction, with identical cluster contents in the two collections.

Also switched legacy algorithms to use unsigned int for barcode decorations to the TrackMeasurementValidation, for consistency with the ACTS version.

FYI @cvarni @avallier @ncalace

added ACTS Tracking labels

@cvarni I rebased on top of !78635 (merged) but I'm getting the following error when running (legacy Reco + adding the ACTS clusters info)

 Reco_tf.py --CA \
--inputRDOFile  /cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/PhaseIIUpgrade/RDO/ATLAS-P2-RUN4-03-00-00/mc21_14TeV.900498.PG_single_muonpm_Pt100_etaFlatnp0_43.recon.RDO.e8481_s4149_r14697/RDO.33675668._000016.pool.root.1 \
--outputAODFile AOD.root \
--steering doRAWtoALL \
--preInclude "InDetConfig.ConfigurationHelpers.OnlyTrackingPreInclude" \
--postInclude "ActsConfig.ActsPostIncludes.ACTSClusterPostInclude" \
--preExec "flags.Tracking.writeExtendedSi_PRDInfo=True" \
--maxEvents 100 

ITkPixelPrepDataToxAOD                            WARNING SiHit information requested, but SiHit collection not available!
ClassIDSvc                                           INFO getRegistryEntries: read 223 CLIDRegistry entries for module ALL
ActsPixelClusterTruthDecoratorAlg                   FATAL Standard std::exception is caught in sysExecute
ActsPixelClusterTruthDecoratorAlg                   ERROR SG::ExcAuxTypeMismatch: Type mismatch for aux variable `::truth_barcode' (511); old type is std::vector<int,std::allocator<int> > new type is std::vector<unsigned int,std::allocator<unsigned int> >.  Old allocator type is std::allocator<std::vector<int> > new allocator type is std::allocator<std::vector<unsigned int> >

Can you confirm if the ClusterTruthDecoratorAlg requires specific RDO inputs with extra SiHit information? Do we have such RDO at hand already?

do we have a working example that shows this works as intended when it comes to produce technical efficiencies with IDTPM/IDPVM? I'm not sure where that computation happens, but if it relies on some cluster-truth matching there may be ambiguity. We may not have 1-to-1 cluster correspondance between offline and the different DP pipelines

mentioned in merge request !78641

@goetz I wanted to compare what was obtained when storing the TrackMeasurementValidationContainer corresponding to the legacy clusters and the ACTS clusters but I've just noticed that we don't have any legacy clusters stored any more apparently. I get in particular the following warning

ITkPixelPrepDataToxAOD                               INFO Missing truth particles 0 missing parent: 0 have 1056
ITkStripPrepDataToxAOD                               INFO Missing truth particles 0 missing parent: 0 have 510

which I believe is somehow connected to !70436 (merged)

On the other hand, the expected clusters are stored for the ACTS collection.

Do you have an idea about what might be wrong on the legacy cluster side?

This can be reproduced running on one of the HITS from the ART tests with

 Reco_tf.py --CA --inputHITSFile HITS.root --outputAODFile AOD.root --steering doRAWtoALL --preInclude "InDetConfig.ConfigurationHelpers.OnlyTrackingPreInclude" --maxEvents 100 --preExec RAWtoALL:"flags.Tracking.writeExtendedSi_PRDInfo=True" --postExec HITtoRDO:"from OutputStreamAthenaPool.OutputStreamConfig import OutputStreamCfg; cfg.merge(OutputStreamCfg(ConfigFlags, \"RDO\", [\"SiHitCollection#*\"]))"

added 79 commits

• 7baa86a0...eb67b19d - 77 commits from branch atlas:main
• aaf83c07 - Added ACTS cluster postInclude
• 65a9376a - Move TrackValidationMeasurement barcode decoration to unsigned int

Compare with previous version

resolved all threads

marked this merge request as ready

FYI @maparo @piazza

This merge request affects 3 packages:

• InnerDetector/InDetConfig
• InnerDetector/InDetEventCnv/InDetPrepRawDataToxAOD
• Tracking/Acts/ActsConfig

Affected files list will not be printed in this case

Adding @tstreble ,@stsuno ,@battagl ,@goetz ,@cgrefe ,@cvarni ,@calfayan ,@sroe ,@jojungge ,@lshan ,@toyamaza ,@pagessin ,@tbold as watchers

added InnerDetector main review-pending-level-1 labels

changed the description

removed InnerDetector main review-pending-level-1 labels

added InnerDetector main review-pending-level-1 labels

CI Result SUCCESS (hash 65a9376a)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

Changes are fine and CI succeeds, approving for L1. -L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 5c7c0483