Skip to content
Snippets Groups Projects

Add strip deltas to fpga output validation

Merged Lucy Lewitt requested to merge llewitt/athena:AddStripDeltasToFPGAOutputValidation into main

Add strip clusters.

cc @zhcui @jahreda @sabidi @wollrath @imaznas

Edited by Lucy Lewitt

Merge request reports

Pipeline #11081472 passed

Pipeline passed for be01da21 on llewitt:AddStripDeltasToFPGAOutputValidation

Approval is optional

Merged by Frank WinklmeierFrank Winklmeier 2 weeks ago (Mar 21, 2025 2:02pm UTC)

Merge details

  • Changes merged into main with 2c5f157b (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Lucy Lewitt resolved all threads

    resolved all threads

  • Lucy Lewitt added 1 commit

    added 1 commit

    Compare with previous version

  • Lucy Lewitt
  • This merge request affects 1 package:

    • Trigger/EFTracking/EFTrackingFPGAIntegration

    This merge request affects 3 files:

    • Trigger/EFTracking/EFTrackingFPGAIntegration/python/FPGAOutputValidationConfig.py
    • Trigger/EFTracking/EFTrackingFPGAIntegration/src/FPGAOutputValidationAlg.cxx
    • Trigger/EFTracking/EFTrackingFPGAIntegration/src/FPGAOutputValidationAlg.h

    Adding @yuchou ,@zhcui as watchers

  • Lucy Lewitt resolved all threads

    resolved all threads

  • Lucy Lewitt added 1 commit

    added 1 commit

    Compare with previous version

  • This merge request affects 1 package:

    • Trigger/EFTracking/EFTrackingFPGAIntegration

    This merge request affects 3 files:

    • Trigger/EFTracking/EFTrackingFPGAIntegration/python/FPGAOutputValidationConfig.py
    • Trigger/EFTracking/EFTrackingFPGAIntegration/src/FPGAOutputValidationAlg.cxx
    • Trigger/EFTracking/EFTrackingFPGAIntegration/src/FPGAOutputValidationAlg.h

    Adding @zhcui ,@yuchou as watchers

  • :x: CI Result FAILURE (hash 764749c2)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • :x: CI Result FAILURE (hash 48cb1974)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Lucy Lewitt marked this merge request as draft

    marked this merge request as draft

    • Author Developer
      Resolved by Lucy Lewitt

      @imaznas Was this test close to timing out previously? Potentially we just disable doing these extra comparsion histograms in the CI?

      https://atlas-sw-build-logs.web.cern.ch/ciwww/CIWebArea/nicos_web_areaMRCIbuilds64BE9G13AthenaOpt/NICOS_TestLog_MR-78659-2025-03-20-13-13/ReleaseTests___CITest_EFTracking_FPGATrackSim_workflow-test__CITest_EFTracking_FPGATrackSim_workflow-test__m.html

      ---------------------------
      Run time for this test (CITest_EFTracking_FPGATrackSim_workflowtest) was 3600.16
      The test issue message: Timeout
  • Lucy Lewitt
  • Lucy Lewitt
  • Lucy Lewitt
  • Lucy Lewitt
  • Lucy Lewitt
  • Lucy Lewitt
  • Lucy Lewitt resolved all threads

    resolved all threads

  • Lucy Lewitt resolved all threads

    resolved all threads

  • Lucy Lewitt added 1 commit

    added 1 commit

    • be01da21 - Disable diff histograms by default.

    Compare with previous version

  • Author Developer

    Jenkins please retry a build

  • This merge request affects 1 package:

    • Trigger/EFTracking/EFTrackingFPGAIntegration

    This merge request affects 3 files:

    • Trigger/EFTracking/EFTrackingFPGAIntegration/python/FPGAOutputValidationConfig.py
    • Trigger/EFTracking/EFTrackingFPGAIntegration/src/FPGAOutputValidationAlg.cxx
    • Trigger/EFTracking/EFTrackingFPGAIntegration/src/FPGAOutputValidationAlg.h

    Adding @zhcui ,@yuchou as watchers

  • :white_check_mark: CI Result SUCCESS (hash be01da21)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading