Skip to content
Snippets Groups Projects

Add mc23a tracking fake rate+efficiency recommendations and clean up tracking CP tools

Merged Add mc23a tracking fake rate+efficiency recommendations and clean up tracking CP tools
mvessell/athena:truthfilterupdate into main
All threads resolved!
Merged Makayla Vessella requested to merge mvessell/athena:truthfilterupdate into main
All threads resolved!

This MR adds recommendations for MC23a to the tracking CP tools and removes some deprecated functions and features to reduce end-user confusion, in preparation for development of CP algs. The configs are also updated to prevent improper configuring of the tools where recommendations are not available.

FYI @tstreble @ncalace @rgarg @jburzyns @oducu @xai

Edited by Makayla Vessella

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/python/InDetTrackSystematicsToolsConfig.py
21 21 if "trackOriginTool" not in kwargs:
22 22 kwargs.setdefault("trackOriginTool", acc.popToolsAndMerge(
23 23 InDetTrackTruthOriginToolCfg(flags)))
24
25 from AthenaConfiguration.Enums import LHCPeriod
26 # Run 3 recommendations (MC23)
27 if flags.GeoModel.Run == LHCPeriod.Run3:
  • Makayla Vessella
    Makayla Vessella @mvessell ·
    Author Developer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools

    This merge request affects 7 files:

    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/InDetTrackSystematicsTools/IInDetTrackTruthFilterTool.h
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/InDetTrackSystematicsTools/InDetTrackSystematics.h
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/InDetTrackSystematicsTools/InDetTrackTruthFilterTool.h
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/InDetTrackSystematicsTools/InclusiveTrackFilterTool.h
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/Root/InDetTrackTruthFilterTool.cxx
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/Root/InclusiveTrackFilterTool.cxx
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/python/InDetTrackSystematicsToolsConfig.py

    Adding @jburzyns ,@dshope as watchers

  • ATLAS Robot added Analysis analysis-review-required main labels

    added Analysis analysis-review-required main labels

  • Makayla Vessella changed the description

    changed the description

  • Thomas Strebler
  • Thomas Strebler
  • Thomas Strebler added Recommendation analysis-interface-change labels

    added Recommendation analysis-interface-change labels

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :scissors: CI integration tests for projects AnalysisBase are cancelled because of compilation error(s)

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :x: CI Result FAILURE (hash 707fc76e)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :o: :white_check_mark:
    tests :white_check_mark: :no_entry_sign: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :o: AnalysisBase: number of compilation errors 1, warnings 14
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Thomas Strebler
  • Thomas Strebler
  • Makayla Vessella added 1 commit

    added 1 commit

    • 34ef16e0 - address threads and update to Gaudi::property

    Compare with previous version

  • Thomas Strebler
  • Makayla Vessella added 1 commit

    added 1 commit

    • 4f85eeb6 - further remove deprecated properties

    Compare with previous version

  • Makayla Vessella
    Makayla Vessella @mvessell ·
    Author Developer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools

    This merge request affects 7 files:

    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/InDetTrackSystematicsTools/IInDetTrackTruthFilterTool.h
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/InDetTrackSystematicsTools/InDetTrackSystematics.h
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/InDetTrackSystematicsTools/InDetTrackTruthFilterTool.h
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/InDetTrackSystematicsTools/InclusiveTrackFilterTool.h
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/Root/InDetTrackTruthFilterTool.cxx
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/Root/InclusiveTrackFilterTool.cxx
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/python/InDetTrackSystematicsToolsConfig.py

    Adding @dshope ,@jburzyns as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :scissors: CI integration tests for projects AnalysisBase are cancelled because of compilation error(s)

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :x: CI Result FAILURE (hash 4f85eeb6)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :o: :white_check_mark:
    tests :white_check_mark: :no_entry_sign: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :o: AnalysisBase: number of compilation errors 1, warnings 7
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Thomas Strebler
  • Makayla Vessella added 1 commit

    added 1 commit

    Compare with previous version

  • Makayla Vessella marked this merge request as ready

    marked this merge request as ready

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools

    This merge request affects 7 files:

    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/InDetTrackSystematicsTools/IInDetTrackTruthFilterTool.h
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/InDetTrackSystematicsTools/InDetTrackSystematics.h
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/InDetTrackSystematicsTools/InDetTrackTruthFilterTool.h
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/InDetTrackSystematicsTools/InclusiveTrackFilterTool.h
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/Root/InDetTrackTruthFilterTool.cxx
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/Root/InclusiveTrackFilterTool.cxx
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/python/InDetTrackSystematicsToolsConfig.py

    Adding @jburzyns ,@dshope as watchers

  • ATLAS Robot added review-pending-level-1 label

    added review-pending-level-1 label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :x: CI Result FAILURE (hash 163adff0)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :o: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Fabio Lucio Lucio Alves
    Fabio Lucio Lucio Alves @falves ·
    Developer

    Hi @mvessell ! Could you please have a look at the CI tests failure and unresolved threads? Thanks, L1 (Fábio).

    Edited by Fabio Lucio Lucio Alves
  • Fabio Lucio Lucio Alves removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Fabio Lucio Lucio Alves added MuonSpectrometer review-user-action-required labels

    added MuonSpectrometer review-user-action-required labels

  • Fabio Lucio Lucio Alves removed MuonSpectrometer label

    removed MuonSpectrometer label

  • K
    Nils Erik Krumnack @krumnack ·
    Developer

    A recommendation update and removal of code that was marked as deprecated, approving for AR.

    Nils [Analysis RC]

  • Nils Erik Krumnack added analysis-review-approved label and removed analysis-review-required label

    added analysis-review-approved label and removed analysis-review-required label

  • Michael Holzbock mentioned in merge request !78852 (merged)

    mentioned in merge request !78852 (merged)

  • Thomas Strebler resolved all threads

    resolved all threads

  • Thomas Strebler
    Thomas Strebler @tstreble ·
    Developer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools

    This merge request affects 7 files:

    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/InDetTrackSystematicsTools/IInDetTrackTruthFilterTool.h
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/InDetTrackSystematicsTools/InDetTrackSystematics.h
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/InDetTrackSystematicsTools/InDetTrackTruthFilterTool.h
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/InDetTrackSystematicsTools/InclusiveTrackFilterTool.h
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/Root/InDetTrackTruthFilterTool.cxx
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/Root/InclusiveTrackFilterTool.cxx
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/python/InDetTrackSystematicsToolsConfig.py

    Adding @dshope ,@jburzyns as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 163adff0)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Lukas Kretschmann
    Lukas Kretschmann @lkretsch ·
    Developer

    Changes are fine and CI succeeds, approving for L1. -L1

  • Lukas Kretschmann added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Vakhtang Tsulaia merged

    merged

  • Vakhtang Tsulaia mentioned in commit 7bd169ba

    mentioned in commit 7bd169ba

  • Thomas Strebler mentioned in merge request !79198

    mentioned in merge request !79198

    • Please register or sign in to reply