Skip to content
Snippets Groups Projects

Add mc23a tracking fake rate+efficiency recommendations and clean up tracking CP tools

Open Add mc23a tracking fake rate+efficiency recommendations and clean up tracking CP tools
mvessell/athena:truthfilterupdate into main
Open Makayla Vessella requested to merge mvessell/athena:truthfilterupdate into main

This MR adds recommendations for MC23a to the tracking CP tools and removes some deprecated functions and features to reduce end-user confusion, in preparation for development of CP algs. The configs are also updated to prevent improper configuring of the tools where recommendations are not available.

FYI @tstreble @ncalace @rgarg @jburzyns @oducu @xai

Edited by Makayla Vessella

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/python/InDetTrackSystematicsToolsConfig.py
21 21 if "trackOriginTool" not in kwargs:
22 22 kwargs.setdefault("trackOriginTool", acc.popToolsAndMerge(
23 23 InDetTrackTruthOriginToolCfg(flags)))
24
25 from AthenaConfiguration.Enums import LHCPeriod
26 # Run 3 recommendations (MC23)
27 if flags.GeoModel.Run == LHCPeriod.Run3:
  • Makayla Vessella
    Makayla Vessella @mvessell ·
    Author Developer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools

    This merge request affects 7 files:

    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/InDetTrackSystematicsTools/IInDetTrackTruthFilterTool.h
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/InDetTrackSystematicsTools/InDetTrackSystematics.h
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/InDetTrackSystematicsTools/InDetTrackTruthFilterTool.h
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/InDetTrackSystematicsTools/InclusiveTrackFilterTool.h
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/Root/InDetTrackTruthFilterTool.cxx
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/Root/InclusiveTrackFilterTool.cxx
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/python/InDetTrackSystematicsToolsConfig.py

    Adding @jburzyns ,@dshope as watchers

  • ATLAS Robot added Analysis analysis-review-required main labels

    added Analysis analysis-review-required main labels

  • Makayla Vessella changed the description

    changed the description

  • Thomas Strebler
  • Thomas Strebler
  • Thomas Strebler added Recommendation analysis-interface-change labels

    added Recommendation analysis-interface-change labels

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :scissors: CI integration tests for projects AnalysisBase are cancelled because of compilation error(s)

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :x: CI Result FAILURE (hash 707fc76e)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :o: :white_check_mark:
    tests :white_check_mark: :no_entry_sign: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :o: AnalysisBase: number of compilation errors 1, warnings 14
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Thomas Strebler
  • Thomas Strebler
  • Makayla Vessella added 1 commit

    added 1 commit

    • 34ef16e0 - address threads and update to Gaudi::property

    Compare with previous version

  • Thomas Strebler
    Thomas Strebler @tstreble started a thread on an old version of the diff
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/Root/InDetTrackTruthFilterTool.cxx
    42 39
    43 40 InDetTrackTruthFilterTool::InDetTrackTruthFilterTool(const std::string& name) :
    44 41 InDetTrackSystematicsTool(name),
    45 m_trackOriginTool("InDet::InDetTrackTruthOriginTool", this)
    42 m_trackOriginTool(this, "trackOriginTool", "InDet::InDetTrackTruthOriginTool/InDetTrackTruthOriginTool", "Tool to get the truth origin of a track"),
    43 m_seed(this, "Seed", 0, "Random seed"),
    44 m_fPrim(this, "fPrim", 0.0, "Primary fraction"),
    45 m_fSec(this, "fSec", 0.0, "Secondary fraction"),
    46 m_fFakeLoose(this, "fFakeLoose", -1.0, "Fake loose fraction"),
    47 m_fFakeTight(this, "fFakeTight", -1.0, "Fake tight fraction"),
    48 m_fPU(this, "fPU", 0.0, "Pileup fraction"),
    49 m_fFrag(this, "fFrag", 0.0, "Fragmentation fraction"),
    50 m_fFromC(this, "fFromC", 0.0, "From C fraction"),
    51 m_fFromB(this, "fFromB", 0.0, "From B fraction"),
    52 m_trkEffSystScale(this, "trkEffSystScale", 1.0, "Track efficiency systematic scale"),
    53 m_calibFileNomEff(this, "calibFileNomEff", "", "Calibration file for nominal efficiency")
  • Makayla Vessella added 1 commit

    added 1 commit

    • 4f85eeb6 - further remove deprecated properties

    Compare with previous version

  • Makayla Vessella
    Makayla Vessella @mvessell ·
    Author Developer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools

    This merge request affects 7 files:

    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/InDetTrackSystematicsTools/IInDetTrackTruthFilterTool.h
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/InDetTrackSystematicsTools/InDetTrackSystematics.h
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/InDetTrackSystematicsTools/InDetTrackTruthFilterTool.h
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/InDetTrackSystematicsTools/InclusiveTrackFilterTool.h
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/Root/InDetTrackTruthFilterTool.cxx
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/Root/InclusiveTrackFilterTool.cxx
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools/python/InDetTrackSystematicsToolsConfig.py

    Adding @dshope ,@jburzyns as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :scissors: CI integration tests for projects AnalysisBase are cancelled because of compilation error(s)

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :x: CI Result FAILURE (hash 4f85eeb6)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :o: :white_check_mark:
    tests :white_check_mark: :no_entry_sign: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :o: AnalysisBase: number of compilation errors 1, warnings 7
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
    • Please register or sign in to reply