Fix filling of barcode decoration for xAOD::TrackMeasurementValidationContainer

Follow up to !69866 (merged)

The decoration truth_barcode was not filled because in the first loop used to fill the truth_index a reference was used, leading to an update of range.first when the iterator was incremented. As a consequence the 2nd loop didn't have the proper range.

FYI @goetz @cvarni

added bugfix label

mentioned in merge request !78645 (merged)

This merge request affects 1 package:

• InnerDetector/InDetEventCnv/InDetPrepRawDataToxAOD

This merge request affects 2 files:

• InnerDetector/InDetEventCnv/InDetPrepRawDataToxAOD/src/PixelPrepDataToxAOD.cxx
• InnerDetector/InDetEventCnv/InDetPrepRawDataToxAOD/src/SCT_PrepDataToxAOD.cxx

Adding @battagl ,@sroe ,@lshan ,@goetz ,@stsuno as watchers

added InnerDetector main review-pending-level-1 labels

CI Result SUCCESS (hash b529a32a)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

Changes are fine and CI succeeds, approving for L1. -L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit a16637a8