From b09da3577b49febd77f1e723d4c929a127136d98 Mon Sep 17 00:00:00 2001
From: Federica Piazza <federica.piazza@cern.ch>
Date: Fri, 21 Mar 2025 10:16:52 -0500
Subject: [PATCH] -a
---
.../src/OfflineObjectDecorHelper.cxx | 13 -------------
.../src/OfflineObjectDecorHelper.h | 5 -----
.../InDetTrackPerfMon/src/TrackAnalysisPlotsMgr.cxx | 10 ++++------
3 files changed, 4 insertions(+), 24 deletions(-)
diff --git a/InnerDetector/InDetValidation/InDetTrackPerfMon/src/OfflineObjectDecorHelper.cxx b/InnerDetector/InDetValidation/InDetTrackPerfMon/src/OfflineObjectDecorHelper.cxx
index 0995303cfbb9..5e8fff1d4585 100644
--- a/InnerDetector/InDetValidation/InDetTrackPerfMon/src/OfflineObjectDecorHelper.cxx
+++ b/InnerDetector/InDetValidation/InDetTrackPerfMon/src/OfflineObjectDecorHelper.cxx
@@ -68,19 +68,6 @@ namespace IDTPM {
track, "truthParticleLink" );
}
- /// isFake
- bool isFakeTruth( const xAOD::TrackParticle& track,
- const float truthProbCut,
- const bool unlinkedAsFakes )
- {
- /// if fakes include unlinked, return true if isUnlinked is true
- if( unlinkedAsFakes and isUnlinkedTruth( track ) ) return true;
- float prob = getTruthMatchProb( track );
- /// returns true if truthMatchProbability deco isn't available or
- /// if the truth matching probability is below theshold
- return ( prob < truthProbCut );
- }
-
/// isReconstructable
bool isReconstructable( const xAOD::TruthParticle& truth,
const std::vector<unsigned int>& minSilHits,
diff --git a/InnerDetector/InDetValidation/InDetTrackPerfMon/src/OfflineObjectDecorHelper.h b/InnerDetector/InDetValidation/InDetTrackPerfMon/src/OfflineObjectDecorHelper.h
index fc5b20685861..98e3f311312f 100644
--- a/InnerDetector/InDetValidation/InDetTrackPerfMon/src/OfflineObjectDecorHelper.h
+++ b/InnerDetector/InDetValidation/InDetTrackPerfMon/src/OfflineObjectDecorHelper.h
@@ -82,11 +82,6 @@ namespace IDTPM {
inline const xAOD::TruthParticle* getLinkedTruth(
const xAOD::TruthParticle&, const float ) { return nullptr; }; // dummy - to avoid compilation errors
- bool isFakeTruth( const xAOD::TrackParticle& track,
- const float truthProbCut=0., const bool unlinkedAsFakes=false );
- inline bool isFakeTruth( const xAOD::TruthParticle&,
- const float, const bool ) { return false; }; // dummy - to avoid compilation errors
-
bool isReconstructable( const xAOD::TruthParticle& truth,
const std::vector< unsigned int >& minSilHits,
const std::vector< float >& etaBins);
diff --git a/InnerDetector/InDetValidation/InDetTrackPerfMon/src/TrackAnalysisPlotsMgr.cxx b/InnerDetector/InDetValidation/InDetTrackPerfMon/src/TrackAnalysisPlotsMgr.cxx
index 402c978dd0fc..a9b64b233436 100644
--- a/InnerDetector/InDetValidation/InDetTrackPerfMon/src/TrackAnalysisPlotsMgr.cxx
+++ b/InnerDetector/InDetValidation/InDetTrackPerfMon/src/TrackAnalysisPlotsMgr.cxx
@@ -366,10 +366,10 @@ StatusCode IDTPM::TrackAnalysisPlotsMgr::fillPlotsTest(
/// fake rate plots (and hits on fake plots)
bool isUnlinked = isUnlinkedTruth( *particle );
- bool notTruthMatched = getTruthMatchProb( *particle ) < 0.5;
+ bool isFakeTruth = getTruthMatchProb( *particle ) < m_trkAnaDefSvc->truthProbCut();
if ( isUnlinked ) {
if( m_plots_missingTruth ) {
- ATH_CHECK( m_plots_missingTruth->fillPlots( *particle, notTruthMatched, truthMu, actualMu, weight ) );
+ ATH_CHECK( m_plots_missingTruth->fillPlots( *particle, isFakeTruth, truthMu, actualMu, weight ) );
}
if( m_plots_hitsOnUnlinkedTrk ) {
ATH_CHECK( m_plots_hitsOnUnlinkedTrk->fillPlots( *particle, truthMu, actualMu, weight ) );
@@ -378,10 +378,8 @@ StatusCode IDTPM::TrackAnalysisPlotsMgr::fillPlotsTest(
bool doFakes = m_trkAnaDefSvc->unlinkedAsFakes() ? true : not isUnlinked;
if( doFakes and m_plots_fakeRate ) {
- bool isFake = isFakeTruth( *particle, m_trkAnaDefSvc->truthProbCut(),
- m_trkAnaDefSvc->unlinkedAsFakes() );
- ATH_CHECK( m_plots_fakeRate->fillPlots( *particle, isFake, truthMu, actualMu, weight ) );
- if( m_plots_hitsOnFakeTrk and isFake ) {
+ ATH_CHECK( m_plots_fakeRate->fillPlots( *particle, isFakeTruth, truthMu, actualMu, weight ) );
+ if( m_plots_hitsOnFakeTrk and isFakeTruth ) {
ATH_CHECK( m_plots_hitsOnFakeTrk->fillPlots( *particle, truthMu, actualMu, weight ) );
}
}
--
GitLab