In case fullName is not found by trf, avoiding exception
In some recent grid jobs, cvmfs goes stale. In those cases, the file that this piece of code is looking for won't be found. Right now it looks for the file, identifies that it isn't there, and prints a warning (because the filename is None). It then tries to open the file anyway. Looking at the code, I can't imagine that's what was intended, because even in the case that it fails to open the code because of an OSError it just prints a warning and continues. Therefore adding an 'else' here to avoid opening the file in case the name is None. This could also be done by catching a TypeError exception, but I don't see why we should use try/except logic when we have a nice clean way to test for the condition with an if statement (and we already do).
Merge request reports
Activity
added Tools main review-pending-level-1 labels
CI Result SUCCESS (hash f2bf3c8e)Athena AthSimulation AthGeneration externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)added review-approved label and removed review-pending-level-1 label
mentioned in commit 19a65cb5