Skip to content
Snippets Groups Projects

Fix in the MuonDetectorNav test to get the closest from the propagated hits when we have multiple in the same tube layer and add global pos information

Merged Fix in the MuonDetectorNav test to get the closest from the propagated hits when we have multiple in the same tube layer and add global pos information
damperia/athena:fix-detnav-test into main
All threads resolved!
Merged Dimitra Amperiadou requested to merge damperia/athena:fix-detnav-test into main
All threads resolved!
  • Improve the propagation <-> hit matching by also checking whether there're multiple truth hits in the same tube layer and then by picking the closest one
  • Add global propgation position & path length as extra tree variables
Edited by Johannes Junggeburth

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Johannes Junggeburth
  • Dimitra Amperiadou resolved all threads

    resolved all threads

  • Dimitra Amperiadou resolved all threads

    resolved all threads

  • Dimitra Amperiadou added 1 commit

    added 1 commit

    • 4624950b - Apply 2 suggestion(s) to 1 file(s)

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • MuonSpectrometer/MuonPhaseII/MuonDetDescr/ActsMuonDetectorTest

    This merge request affects 2 files:

    • MuonSpectrometer/MuonPhaseII/MuonDetDescr/ActsMuonDetectorTest/src/MuonDetectorNavTest.cxx
    • MuonSpectrometer/MuonPhaseII/MuonDetDescr/ActsMuonDetectorTest/src/MuonDetectorNavTest.h

    Adding @mvozak ,@jojungge ,@wleight ,@stavrop ,@cvarni ,@toyamaza ,@tbold ,@apsallid ,@pscholer ,@pagessin ,@markowen ,@ddicroce ,@kluit as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash d4a9ec63)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Johannes Junggeburth added review-approved label

    added review-approved label

  • Johannes Junggeburth removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Johannes Junggeburth added review-pending-level-1 label

    added review-pending-level-1 label

  • Johannes Junggeburth removed review-approved label

    removed review-approved label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 4624950b)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Johannes Junggeburth added review-approved label

    added review-approved label

  • Johannes Junggeburth removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Vakhtang Tsulaia merged

    merged

  • Vakhtang Tsulaia mentioned in commit ee19b3a6

    mentioned in commit ee19b3a6

    • Please register or sign in to reply