Skip to content
Snippets Groups Projects

2025-03-26: merge of 24.0 into main

Closed Vakhtang Tsulaia requested to merge tsulaia/athena:sweep_24.0_main_2025-03-26 into main
All threads resolved!

We have several conflicts on this sweep.

The first set of conflicts was generated by !78710 (merged), cc @pscholer. It was not always obvious how to resolve the conflicts, so I had to use my "educated guess". Most likely, I did something wrong here, so please check the results of the conflict resolutions. As a general note/guideline, I think it would be much more straightforward to mark such complex MR-s in 24.0 as sweep:ignore so that they will be excluded from daily sweeps, and then apply relevant changes directly to main in a separate MR.

Anyway, here is a list of conflicting files from this MR and how I approached to the resolution of conflicts.

Manual resolution:

  1. MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondAlg/src/components/MuonCondAlg_entries.cxx
  2. MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry/MuonReadoutGeometry/MuonDetectorManager.h
  3. MuonSpectrometer/MuonPhaseII/MuonConditions/MuonAlignmentDataR4/MuonAlignmentDataR4/sTgcAlignmentStore.h

Kept the main version:

  1. MuonSpectrometer/MuonConfig/python/MuonConfigFlags.py
  2. MuonSpectrometer/MuonConfig/python/MuonGeometryConfig.py
  3. MuonSpectrometer/MuonPhaseII/MuonConditions/MuonCondAlgR4/src/ActsMuonAlignCondAlg.cxx

Kept the 24.0 version:

  1. MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry/src/sTgcReadoutElement.cxx

One last conflict was on the file PhysicsAnalysis/DerivationFramework/DerivationFrameworkL1Calo/python/L1CALOCore.py triggered by !78790 (merged), cc @thompson. Again, I used the "educated guess" approach to resolve the conflict manually. Most likely the result is wrong. Please double check.

This sweep contains the following MRs:

Edited by Vakhtang Tsulaia

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading