Added mitigation for module defects in acts track finder.

Use detector element status to mark surfaces associated to detector elements which are marked as defect as insensitive. Holes observed for such surfaces will not be counted.

To identify the correct detector element status container for a certain Acts surface, additional conditions data is created which maps Acts volumes to the current detector element collection. The latter can be used subsequently to find the associated detector element status container.

This merge request affects 3 packages:

• Tracking/Acts/ActsConfig
• Tracking/Acts/ActsGeometry
• Tracking/Acts/ActsTrackReconstruction

Affected files list will not be printed in this case

Adding @cvarni ,@goetz ,@pagessin ,@adye ,@jojungge ,@tbold ,@toyamaza as watchers

added ACTS Tracking main review-pending-level-1 labels

changed the description

When emulating some defects e.g. with emulateITkPixelDefectsDefault and emulateITkStripDefectsDefault, the number of holes counted by the Acts track finder decreases when propagating these defects to the detector element status and the technical efficiency increases slightly.

Instead of marking all surfaces as insensitive which are associated to modules which are marked as defect in the detector element status before the execution of the CKF, the detector element status could be evaluated directly for each surface on which compatible measurements are searched (goetz/athena:ActsDefectMitigation_main_test_just_before_measurement_slection ). However, the latter leads to a slight increase in total runtime in an Acts tracking only ttbar (PU200) reconstruction job. Thus, this MR proposes the former method.

CI Result FAILURE (hash 6e87dcd1)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

added 2 commits

• 12305fab - Add algorithm to map acts volume id to detector element collections.
• 44899aac - Added mitigation for module defects in acts track finder.

Compare with previous version

This merge request affects 3 packages:

• Tracking/Acts/ActsConfig
• Tracking/Acts/ActsGeometry
• Tracking/Acts/ActsTrackReconstruction

Affected files list will not be printed in this case

Adding @pagessin ,@adye ,@cvarni ,@tbold ,@jojungge ,@goetz ,@toyamaza as watchers

above changes:

• reduced verbosity

added ITk label

CI Result FAILURE (hash 44899aac)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

The failure of the EFTracking/FPGATrackSim_workflow test (FPEs) occur with and without this MR, and has been seen elsewhere (EFTRACK-524), So, is likely not related to this MR.

Jenkins please retry a build

This merge request affects 3 packages:

• Tracking/Acts/ActsConfig
• Tracking/Acts/ActsGeometry
• Tracking/Acts/ActsTrackReconstruction

Affected files list will not be printed in this case

Adding @cvarni ,@toyamaza ,@pagessin ,@adye ,@goetz ,@jojungge ,@tbold as watchers

CI Result SUCCESS (hash 44899aac)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

Changes look good to me. Escalating to L2 to double check. L1 (Fábio).

removed review-pending-level-1 label

added review-pending-level-2 label

Aside from the small comment, looks good.

@goetz, feel free to adjust if you agree with the suggestion and then skip to level-2 or marked reviewed when CI build completes with no error.

Otherwise I'll check again end of day.

Karolos (L2)

resolved all threads

Looks good. Karolos (L2)

added review-approved label

removed review-pending-level-2 label

resolved all threads

merged

mentioned in commit a516336f