Set MC campaign centrally for MC trigger ART tests
While the correct MC campaign & settings were being used in TrigAnalysisTest
transform-driven ART jobs running MC trigger simulation, the lack of preInclude support in runHLT.py
meant that we were using the (bad) default settings for the LAr pileup simulation among other things, which was the source of ATR-28710.
To fix this in the many MC tests, this MR therefore:
- Adds (pre/post)(Exec/Include) support to
runHLT
viaTransformUtils
--postExec
was already supported via bespoke code in !65198 (merged) - Adds a module providing template MC build & grid tests with just one place to commonly configure the global tag and MC campaign via flags & preInclude. These can be overridden cleanly (and only) through the
MCExecStep
constructor. - Adapt all
TriggerTest
MC jobs to use the commonMCExecStep
classes.
The HI, Cosmic, LowMu, and ITk tests use the MC campaign settings deemed most appropriate.
If we like this model, we could also do something similar for the test_trig_data
jobs, but those do not have the same issue of the boilerplate conditions setup.
N.B. the HI Campaigns needed to ditch the doAlfaCtpin
flag because this doesn't exist anymore (along with ALFA). Trigger simulation for ALFA, while needed for 2023, would be done in an older release.
Merge request reports
Activity
I am a bit curious about a couple of inconsistencies in the various test configs:
- Only the MC muon grid test sets
ex.imf=False
- A handful of HI and lowMu tests set
Trigger.doRuntimeNaviVal=True
. But specifically the lowMu build and grid tests do not set this consistently.
For now I have preserved the exact setup for all tests, apart from enabling the MC campaign (standard Run 3 except for the ITk tests where the corresponding Phase II campaign preInclude is set), and making the MC build test consistently use the same default global conditions tag as everything else.
- Only the MC muon grid test sets
added 24.0 Egamma ITk Trigger full-unit-tests labels
CI Result FAILURE (hash 95670428)Athena AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info) CI Result FAILURE (hash a815da73)Athena AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)added 1 commit
- e8d0a64c - Switch to dedicated MC conditions for HI and low mu
added Tools analysis-review-required changes-trigger-counts labels
@jchapman FYI, removed the obsolete flag from MC23 HI config function as discussed. Seems better to activate this for the HI tests even if not finalised, such that when it is, it is reflected in our ART.
Note: Cosmics didn't have any dedicated
Campaign
setup so just gets default. I am a bit sceptical that mu=60 for low-mu is reflective of detector settings, but would settle for using that configuration in our tests and leaving it to others to determine what the correct settings ought to be.- Resolved by Teng Jian Khoo
It would probably be better to use the
MC23a/d/e/gNoPileUp
setup for cosmics; what do you think?