Skip to content
Snippets Groups Projects

Set MC campaign centrally for MC trigger ART tests

Merged Teng Jian Khoo requested to merge khoo/athena:24.0-TrigVal-MCCampaign into 24.0

While the correct MC campaign & settings were being used in TrigAnalysisTest transform-driven ART jobs running MC trigger simulation, the lack of preInclude support in runHLT.py meant that we were using the (bad) default settings for the LAr pileup simulation among other things, which was the source of ATR-28710.

To fix this in the many MC tests, this MR therefore:

  1. Adds (pre/post)(Exec/Include) support to runHLT via TransformUtils -- postExec was already supported via bespoke code in !65198 (merged)
  2. Adds a module providing template MC build & grid tests with just one place to commonly configure the global tag and MC campaign via flags & preInclude. These can be overridden cleanly (and only) through the MCExecStep constructor.
  3. Adapt all TriggerTest MC jobs to use the common MCExecStep classes.

The HI, Cosmic, LowMu, and ITk tests use the MC campaign settings deemed most appropriate.

If we like this model, we could also do something similar for the test_trig_data jobs, but those do not have the same issue of the boilerplate conditions setup.

FYI @lbeemste @martindl

N.B. the HI Campaigns needed to ditch the doAlfaCtpin flag because this doesn't exist anymore (along with ALFA). Trigger simulation for ALFA, while needed for 2023, would be done in an older release.

Edited by Teng Jian Khoo

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading