TrigT1NSWSimTools: simplified MM trigger workflow pt.2

As anticipated in !79056 (merged) and asked by @jojungge many months ago, this MR reduces redundant steps and removes obsolete methods/classes in MM trigger workflow. Changelog:

• Complete removal of MMT_struct.(cxx/h) garbage files and MMT_Parameters class defined there.
• Removed of all instances of detStore(). Objects are retrieved starting from keys, not anymore stored as private class members.
• Removed convoluted computations and nested structure in MMLoadVariables class. Only computation of truth quantities is left, being disabled by default.
• Digit loop moved in the main workflow, with less operations and lines.
• Fixed a wrong float to int cast when taking digit time.

This rearrangement should make code maintenance easier, as well as simplifying debug operations. As mentioned for the first part, changes will be ported to main manually.

added sweep:ignore label

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 1 package:

• Trigger/TrigT1/TrigT1NSWSimTools

This merge request affects 8 files:

• Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/MMLoadVariables.h
• Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/MMT_Hit.h
• Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/MMT_struct.h
• Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/MMTriggerTool.h
• Trigger/TrigT1/TrigT1NSWSimTools/src/MMLoadVariables.cxx
• Trigger/TrigT1/TrigT1NSWSimTools/src/MMT_Hit.cxx
• Trigger/TrigT1/TrigT1NSWSimTools/src/MMT_struct.cxx
• Trigger/TrigT1/TrigT1NSWSimTools/src/MMTriggerTool.cxx

added 24.0 Trigger review-pending-level-1 labels

CI Result SUCCESS (hash 9464fcb9)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

Approving from L1 side (Fábio).

removed review-pending-level-1 label

added review-approved label

added review-approved-point1 label

mentioned in commit 0eee687f

merged

mentioned in merge request !79222 (merged)

mentioned in merge request !79243 (merged)

Hi @fgravili, just to check, do you expect this to change the output? We see count differences in L1 trigger items that use the NSW coincidence in our nightly tests, and this is the only MR that went in that would impact the L1 muon simulation. (Maybe the float to int cast fix?)

Hi @sshaw , I'm quite sure that's the case. When I checked locally, I saw small increase (~1%) in the output triggers, because the digit time is used to assign hit BC. Other than that, everything is just a refactoring of the code.

OK, great, thanks for confirming!

added changes-trigger-counts label