Skip to content
Snippets Groups Projects

ATLASRECTS-8196: renounce input dependencies in flavor tagging alg

Merged ATLASRECTS-8196: renounce input dependencies in flavor tagging alg
dguest/athena:renounce into 24.0
Merged Dan Guest requested to merge dguest/athena:renounce into 24.0

There were some warnings reported in ATLASRECTS-8196, of the form

SGInputLoader                                          9     2 WARNING    decoration  ( 'xAOD::IParticleContainer' , 'StoreGateSvc+AntiKt4EMPFlowJets.GhostTrack' )  has no provider, and is only Transient - indicative of a missing output declaration

This warning appears because a ReadDecorHandle is declaring a dependency on aux data input which is never "decorated": instead it is created along with the container it is associated with.

This doesn't address most of the reported problems, but it addresses the one above. I found one algorithm that was declaring dependencies on aux data which is never decorated to the object it lives on. I don't know where the other warnings are coming from.

We suspected FlavorTagInference::DecoratorAlg, but I'm not convinced that could be the culprit: all the warnings say the decoration is on an xAOD::IParticleContainer and the DecoratorAlg is always declaring dependencies on xAOD::TrackParticleContainer.

At some point we should check whether the warnings all disappear if we set flags.Reco.EnableBTagging=False in the preexec.

Edited by Dan Guest

Merge request reports

Pipeline #11738630 passed

Stage: external

Pipeline passed for 8eb7ab53 on dguest:renounce

Merged by Duc TaDuc Ta 1 week ago (Apr 14, 2025 4:36pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Dan Guest changed title from ATLASRECTS-8196: renounce some input dependencies in some flavor tagging algs to ATLASRECTS-8196: renounce input dependencies in flavor tagging alg

    changed title from ATLASRECTS-8196: renounce some input dependencies in some flavor tagging algs to ATLASRECTS-8196: renounce input dependencies in flavor tagging alg

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • PhysicsAnalysis/JetTagging/FlavorTagInference

    This merge request affects 1 file:

    • PhysicsAnalysis/JetTagging/FlavorTagInference/src/FoldDecoratorAlg.cxx

    Adding @dbaronmo ,@robouque ,@ligang as watchers

  • ATLAS Robot added 24.0 Analysis BTagging JetEtmiss analysis-review-required review-pending-level-1 labels

    added 24.0 Analysis BTagging JetEtmiss analysis-review-required review-pending-level-1 labels

  • Dan Guest changed the description

    changed the description

  • Dan Guest added 2 commits

    added 2 commits

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • PhysicsAnalysis/JetTagging/FlavorTagInference

    This merge request affects 1 file:

    • PhysicsAnalysis/JetTagging/FlavorTagInference/src/FoldDecoratorAlg.cxx

    Adding @robouque ,@ligang ,@dbaronmo as watchers

  • Dan Guest changed the description

    changed the description

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :scissors: CI integration tests for projects Athena,AthAnalysis are cancelled because of compilation error(s)

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :x: CI Result FAILURE (hash 96ace394)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :white_check_mark: :o:
    tests :no_entry_sign: :white_check_mark: :no_entry_sign:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :o: Athena: number of compilation errors 1, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :o: AthAnalysis: number of compilation errors 1, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 8eb7ab53)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Christos Anastopoulos
    Christos Anastopoulos @christos ·
    Developer

    Let me put here as might be relevant https://atlaspmb.web.cern.ch/atlaspmb/spot-mon-rawtoall_data23_mt8/pages/logs/03-04-2025-24.0-x86_64-el9-gcc13-opt-rawtoall_data23_mt8-RAWtoALL

    required by Algorithm:
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FoldHashWithHitsAntiKt4EMPFlowJets
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FoldHashWithoutHitsAntiKt4EMPFlowJets
02:20:52 AvalancheSchedulerSvc                                        0    INFO    o  ( 'xAOD::IParticleContainer' , 'StoreGateSvc+AntiKt4EMPFlowJets.jetRank' )     required by Algorithm:
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FoldHashJetRankAntiKt4EMPFlowJets
02:20:52 AvalancheSchedulerSvc                                        0    INFO    o  ( 'xAOD::IParticleContainer' , 'StoreGateSvc+InDetTrackParticles.numberOfInnermostPixelLayerHits' )     required by Algorithm:
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_201903_rnnip_antikt4empflow_BTagging_AntiKt4EMTopo
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMPFlow
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMTopo
02:20:52 AvalancheSchedulerSvc                                        0    INFO    o  ( 'xAOD::IParticleContainer' , 'StoreGateSvc+InDetTrackParticles.numberOfInnermostPixelLayerSharedHits' )     required by Algorithm:
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_201903_rnnip_antikt4empflow_BTagging_AntiKt4EMTopo
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMPFlow
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMTopo
02:20:52 AvalancheSchedulerSvc                                        0    INFO    o  ( 'xAOD::IParticleContainer' , 'StoreGateSvc+InDetTrackParticles.numberOfInnermostPixelLayerSplitHits' )     required by Algorithm:
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_201903_rnnip_antikt4empflow_BTagging_AntiKt4EMTopo
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMPFlow
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMTopo
02:20:52 AvalancheSchedulerSvc                                        0    INFO    o  ( 'xAOD::IParticleContainer' , 'StoreGateSvc+InDetTrackParticles.numberOfNextToInnermostPixelLayerHits' )     required by Algorithm:
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_201903_rnnip_antikt4empflow_BTagging_AntiKt4EMTopo
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMPFlow
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMTopo
02:20:52 AvalancheSchedulerSvc                                        0    INFO    o  ( 'xAOD::IParticleContainer' , 'StoreGateSvc+InDetTrackParticles.numberOfPixelDeadSensors' )     required by Algorithm:
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_201903_rnnip_antikt4empflow_BTagging_AntiKt4EMTopo
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMPFlow
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMTopo
02:20:52 AvalancheSchedulerSvc                                        0    INFO    o  ( 'xAOD::IParticleContainer' , 'StoreGateSvc+InDetTrackParticles.numberOfPixelHits' )     required by Algorithm:
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_201903_rnnip_antikt4empflow_BTagging_AntiKt4EMTopo
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMPFlow
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMTopo
02:20:52 AvalancheSchedulerSvc                                        0    INFO    o  ( 'xAOD::IParticleContainer' , 'StoreGateSvc+InDetTrackParticles.numberOfPixelHoles' )     required by Algorithm:
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_201903_rnnip_antikt4empflow_BTagging_AntiKt4EMTopo
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMPFlow
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMTopo
02:20:52 AvalancheSchedulerSvc                                        0    INFO    o  ( 'xAOD::IParticleContainer' , 'StoreGateSvc+InDetTrackParticles.numberOfPixelSharedHits' )     required by Algorithm:
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_201903_rnnip_antikt4empflow_BTagging_AntiKt4EMTopo
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMPFlow
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMTopo
02:20:52 AvalancheSchedulerSvc                                        0    INFO    o  ( 'xAOD::IParticleContainer' , 'StoreGateSvc+InDetTrackParticles.numberOfPixelSplitHits' )     required by Algorithm:
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_201903_rnnip_antikt4empflow_BTagging_AntiKt4EMTopo
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMPFlow
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMTopo
02:20:52 AvalancheSchedulerSvc                                        0    INFO    o  ( 'xAOD::IParticleContainer' , 'StoreGateSvc+InDetTrackParticles.numberOfSCTDeadSensors' )     required by Algorithm:
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_201903_rnnip_antikt4empflow_BTagging_AntiKt4EMTopo
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMPFlow
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMTopo
02:20:52 AvalancheSchedulerSvc                                        0    INFO    o  ( 'xAOD::IParticleContainer' , 'StoreGateSvc+InDetTrackParticles.numberOfSCTHits' )     required by Algorithm:
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_201903_rnnip_antikt4empflow_BTagging_AntiKt4EMTopo
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMPFlow
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMTopo
02:20:52 AvalancheSchedulerSvc                                        0    INFO    o  ( 'xAOD::IParticleContainer' , 'StoreGateSvc+InDetTrackParticles.numberOfSCTHoles' )     required by Algorithm:
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_201903_rnnip_antikt4empflow_BTagging_AntiKt4EMTopo
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMPFlow
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMTopo
02:20:52 AvalancheSchedulerSvc                                        0    INFO    o  ( 'xAOD::IParticleContainer' , 'StoreGateSvc+InDetTrackParticles.numberOfSCTSharedHits' )     required by Algorithm:
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_201903_rnnip_antikt4empflow_BTagging_AntiKt4EMTopo
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMPFlow
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMTopo

    So these algorithms

    FtagNN_btagging_201903_rnnip_antikt4empflow_BTagging_AntiKt4EMTopo
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMPFlow
02:20:52 AvalancheSchedulerSvc                                        0    INFO        * FtagNN_btagging_20220314_dipsloose_antikt4empflow_BTagging_AntiKt4EMTopo

    for whatever reason

    require things like

    AvalancheSchedulerSvc                                        0    INFO    o  ( 'xAOD::IParticleContainer' , 'StoreGateSvc+InDetTrackParticles.numberOfSCTSharedHits' )
    Edited by Christos Anastopoulos
  • Dan Guest added bugfix label

    added bugfix label

  • Rui Yuan added analysis-review-approved label and removed analysis-review-required label

    added analysis-review-approved label and removed analysis-review-required label

  • Fabio Lucio Lucio Alves
    Fabio Lucio Lucio Alves @falves ·
    Developer

    Approving from L1 side (Fábio).

  • Fabio Lucio Lucio Alves removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Fabio Lucio Lucio Alves added review-approved label

    added review-approved label

  • Duc Ta added review-approved-tier0 label

    added review-approved-tier0 label

  • Duc Ta mentioned in commit 0b4d7639

    mentioned in commit 0b4d7639

  • Duc Ta merged

    merged

  • Tadej Novak mentioned in merge request !79333 (merged)

    mentioned in merge request !79333 (merged)

Please register or sign in to reply