Merge branch 'mccabe' into 'master'

Add mccabe and backports dependency to flake8

See merge request !508

Build/AtlasLCG/modules/Findmccabe.cmake

+# Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
+#
+# Sets:
+#  MCCABE_PYTHON_PATH
+#
+# Can be steered by MCCABE_LCGROOT.
+#
+
+# The LCG include(s).
+include( LCGFunctions )
+
+# Find it.
+lcg_python_external_module( NAME mccabe
+   PYTHON_NAMES mccabe.py )
+
+# Handle the standard find_package arguments.
+include( FindPackageHandleStandardArgs )
+find_package_handle_standard_args( mccabe DEFAULT_MSG
+   _MCCABE_PYTHON_PATH )
+
+# Set up the RPM dependency.
+lcg_need_rpm( mccabe )

External/PyModules/CMakeLists.txt

@@ -28,9 +28,11 @@ find_package( pip REQUIRED )
 # dependencies are declared correctly and those packages get installed.
 #
 # flake8:
-find_package( functools32 REQUIRED)
-find_package( enum34 REQUIRED)
-find_package( typing REQUIRED)
+find_package( functools32 REQUIRED )
+find_package( enum34 REQUIRED )
+find_package( typing REQUIRED )
+find_package( mccabe REQUIRED )
+find_package( backports REQUIRED )  # for configparser
 
 # A common (temporary) installation directory for all python packages:
 set( _buildDir "${CMAKE_CURRENT_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/PyModulesBuild" )

External/PyModules/README.md

@@ -8,12 +8,9 @@ retrieved from our own [Python package repository](http://atlas-software-dist-eo
 
 To add a new package follow these steps:
 
-1. Download the source from [PyPI](pypi.org) and copy them to our
+1. Download the source and wheel files from [PyPI](pypi.org) and copy them to our
    [repository](http://atlas-software-dist-eos.web.cern.ch/atlas-software-dist-eos/externals/PyModules/repo)
-   on EOS. The directory structure is described in
-   [hosting your own index](https://packaging.python.org/guides/hosting-your-own-index/).
-   Preference should be given to source tarballs. For cases where too many dependencies for a build
-   of the package would be needed, a pre-built "wheel" package (.whl) can be used. This has the
-   danger that it may not work on all of our supported platforms.
+   on EOS. Create an ATLINFR Jira ticket if you don't have permissions yourself. The directory structure
+   is described in [hosting your own index](https://packaging.python.org/guides/hosting-your-own-index/).
 2. Add the package and their version to the [requirements.txt](https://gitlab.cern.ch/atlas/atlasexternals/tree/master/External/PyModules/requirements.txt) file.
 3. Update the CHANGES file in our [repository](http://atlas-software-dist-eos.web.cern.ch/atlas-software-dist-eos/externals/PyModules/repo)