Skip to content

FindGaudi.cmake Fix, main branch (2023.10.08.)

Attila Krasznahorkay requested to merge akraszna/atlasexternals:FindGaudiFix-main-20231008 into main

Allow Gaudi to find ROOT, which in turn (now) needs VDT. Fixing the latest in the line of failures documented in ATLINFR-5071.

@elmsheus, I now went ahead and did a full build on top of dev3/Sat on my trusty Threadripper, to find any other remaining (configuration) issues. As I really got fed up with not having this build going anywhere. 😦 With this change included, the Athena configuration finally succeeds. There are build issues in some packages, but the nightly should be able to handle that. 🤔

Note that this latest failure surprised me a bit. 😕 I was convinced that FindGaudi.cmake would actually end up using FindROOT.cmake out of our own AtlasLCG package. But no, as the nightly is very clear on this, it actually uses ROOT's own CMake configuration directly. 😕

...
CMake Error at /cvmfs/atlas.cern.ch/repo/ATLASLocalRootBase/x86_64/Cmake/3.26.4/Linux-x86_64/share/cmake-3.26/Modules/FindPackageHandleStandardArgs.cmake:230 (message):

  Could NOT find Vdt (missing: VDT_INCLUDE_DIR VDT_LIBRARY)

Call Stack (most recent call first):
  /cvmfs/atlas.cern.ch/repo/ATLASLocalRootBase/x86_64/Cmake/3.26.4/Linux-x86_64/share/cmake-3.26/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  /cvmfs/sft-nightlies.cern.ch/lcg/nightlies/dev3/Sat/ROOT/HEAD/x86_64-centos7-gcc11-opt/cmake/modules/FindVdt.cmake:63 (find_package_handle_standard_args)
  /cvmfs/atlas.cern.ch/repo/ATLASLocalRootBase/x86_64/Cmake/3.26.4/Linux-x86_64/share/cmake-3.26/Modules/CMakeFindDependencyMacro.cmake:76 (find_package)
  /cvmfs/sft-nightlies.cern.ch/lcg/nightlies/dev3/Sat/ROOT/HEAD/x86_64-centos7-gcc11-opt/cmake/ROOTConfig.cmake:132 (find_dependency)
  /build/atnight/localbuilds/nightlies/main--dev3LCG/build/install/AthenaExternals/24.0.14/InstallArea/x86_64-centos7-gcc11-opt/lib/cmake/Gaudi/GaudiDependencies.cmake:114 (find_package)
  /build/atnight/localbuilds/nightlies/main--dev3LCG/build/install/AthenaExternals/24.0.14/InstallArea/x86_64-centos7-gcc11-opt/lib/cmake/Gaudi/GaudiConfig.cmake:132 (include)
  /build/atnight/localbuilds/nightlies/main--dev3LCG/build/install/AthenaExternals/24.0.14/InstallArea/x86_64-centos7-gcc11-opt/cmake/modules/FindGaudi.cmake:53 (find_package)
  CMakeLists.txt:76 (find_package)
...

So we should also just clean up our own FindROOT.cmake at one point, as all the GAUDI_ATLAS parts in it are clearly not needed anymore. (Ever since we switched to including the build of Gaudi in this repository as a "regular external".) Something for @fwinkl or me to do at one point...

Merge request reports