Skip to content
Snippets Groups Projects

CMake Robustness Improvements, main branch (2023.10.08.)

Added various CMake "robustness improvements".

  • Updated FindGaudi.cmake not to make CMake configuration impossible when Gaudi is missing, and to also correctly handle find_package(...) flags (like REQUIRED) when Gaudi is missing;
  • Reduced the message level in some checks in AtlasLibraryFunctions.cmake, to only print a warning when Gaudi is missing in a function call that absolutely needs Gaudi;
  • Finally, made the atlas_add_test(...) function call a bit more robust against using -NOTFOUND strings in its parameters. Which could, in some cases, confuse the existing security checks in the code.

With these in place I am able to generate Makefiles for the Athena project even in "super catastrophic" circumstances, when none of tdaq-common, tdaq or Gaudi are available for the build. The build itself of course fails for almost every package at that point, but at least the build can be attempted.

This, like many recent CMake changes, is related to the efforts around ATLINFR-5071.

Merge request reports

Merged results pipeline #6308491 passed

Merged results pipeline passed for 35afcb44

Approval is optional
Test summary results are being parsed

Merged by Attila KrasznahorkayAttila Krasznahorkay 1 year ago (Oct 8, 2023 2:58pm UTC)

Merge details

  • Changes merged into main with 4d3acfc1.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #6308651 passed

Pipeline passed for 4d3acfc1 on main

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading