Skip to content
Snippets Groups Projects

Add MCFM cmake find module

Merged Johannes Elmsheuser requested to merge elmsheus/atlasexternals:atlasexternals_20240202 into main
All threads resolved!

This is a follow-up to https://its.cern.ch/jira/browse/SPI-2465 and adds a MCFM cmake module to find this MC generator in the LCG builds for Sherpa as this is now available in for LCG_104c_ATLAS_3.

When this will be merged eventually and tagged in a new atlasexternals version, this has be accompanied with find_package( MCFM ) in https://gitlab.cern.ch/atlas/athena/-/blob/main/Generators/Sherpa_i/CMakeLists.txt?ref_type=heads

Follow-up to https://its.cern.ch/jira/browse/SPI-2465

Tagging @ewelina, @akraszna, @cgutscho for feedback and corrections

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Other than these minor comments, I don't have an objection.

  • added 1 commit

    • a2f4219d - Fix a few small issues from the review

    Compare with previous version

  • Johannes Elmsheuser resolved all threads

    resolved all threads

  • Thanks a lot for the suggestions @akraszna ! I've implement them as suggested.

  • mentioned in merge request !1100 (merged)

  • mentioned in commit b30d66c9

  • Please register or sign in to reply
    Loading