Fix syntax error in fatal error
Introduced by !952 (merged), this causes a fatal error when trying to set up a HIP compiler. Longer term we should hopefully be able to just use native CMake HIP support and get rid of this module.
Merge request reports
Activity
I think the lack of support for amd/nvidia platforms is solved in CMake 3.28: https://cmake.org/cmake/help/latest/variable/CMAKE_HIP_PLATFORM.html but haven't been in a position to test it out
assigned to @akraszna
Sure, this is a fine update. But this code for HIP support is indeed on its way out.
I intend to update Control/AthenaExamples/AthExHIP to set up the HIP language with the help of the code from vecmem. As I did for Control/AthenaExamples/AthExSYCL recently already.
I.e. with something like.
# Make use of the SYCL support in VecMem for building this package. find_package( vecmem COMPONENTS LANGUAGE ) # Check if HIP is available as a language. vecmem_check_language( HIP ) if( NOT CMAKE_HIP_COMPILER ) message( STATUS "HIP is not available, not building AthExHIP" ) return() endif() # Enable HIP as a language. enable_language( HIP )
Eventually I also hope that we'll be able to switch to CMake's own implementation. But with the current version, there are still significant missing features unfortunately.
😦 mentioned in commit efc62db6