Skip to content
Snippets Groups Projects

Update to FastjetContrib v1.030

Merged James Ferrando requested to merge jferrand/atlasexternals:master-fjcontrib-0p030 into master

The version of fjcontrib is updated from 1.029 to 1.030. This is a minor change to the fastjetcontrib version. Compilation and linking was checked against the current master athena version.

Merge request reports

Merged by avatar (Apr 28, 2025 8:57am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Developer

    Tagging also JIRA (ATLJETMET-783)

    eventually will be wanted for use in 21.2

    Edited by James Ferrando
  • Author Developer

    Hi @akraszna, do I need to do anything special for this to enter the pipeline?

  • No, this looks fine, I was just not finding any time recently to look at this repository...

  • mentioned in commit 4c828828

  • Hi @akraszna - Can you provide some guidance on how to use this updated version of this external? I am trying to follow these two sources :

    I feel like this is necessary since this upgrade now lives in a version of atlasexternals that is not yet in a release but its not clear when that will happen and we would like to start developing. So my hope was to include atlas externals as a submodule and then use a package_filters.txt to selectively compile FastJet and FastJetContrib from this local clone of atlasexternals.

    However, I am continually getting a

    Scanning dependencies of target testRun_fjcontrib
    [ 94%] Building CXX object testrun/CMakeFiles/testRun_fjcontrib.dir/main.cxx.o
    /afs/cern.ch/work/m/meehan/public/MyTest/LocalFastJetContribExample/testrun/main.cxx:12:48: fatal error: fastjet/contrib/RecursiveSoftDrop.hh: No such file or directory
     #include "fastjet/contrib/RecursiveSoftDrop.hh"
                                                    ^
    compilation terminated.
    make[2]: *** [testrun/CMakeFiles/testRun_fjcontrib.dir/main.cxx.o] Error 1
    make[1]: *** [testrun/CMakeFiles/testRun_fjcontrib.dir/all] Error 2
    make: *** [all] Error 2

    error, indicating to me that the path to the includes is still pointing to the central ATLASExternals. This is the case when I print the include and library paths for FastJetContrib

    -- PrintVariable FASTJETCONTRIB_INCLUDE_DIRS is: /cvmfs/atlas.cern.ch/repo/sw/software/21.2/AnalysisBaseExternals/21.2.4/InstallArea/x86_64-slc6-gcc62-opt/include
    -- PrintVariable FASTJETCONTRIB_LIBRARIES is: /cvmfs/atlas.cern.ch/repo/sw/software/21.2/AnalysisBaseExternals/21.2.4/InstallArea/x86_64-slc6-gcc62-opt/lib/libRecursiveTools.a

    but I can't determine how to include them properly.

    I think it has something to do with using the CONFIG version of find_packages() instead of the MODULE version which it seems like it currently uses, but I am failing to determine how to properly use this.

    I apologize if this is not the right forum for this question, I can send a mail. I just thought it would here be attached to an appropriate GitLab discussion. Once I get this, I will be sure to document it on the JSV page.

Please register or sign in to reply
Loading