Skip to content

ATLAS_PLATFORM Handling Update, 1.0 branch (2018.06.21.)

Attila Krasznahorkay requested to merge akraszna/atlasexternals:PlatformHandlingFix-1.0-20180621 into 1.0

This is to fix the issue described in ATLINFR-2388. To avoid CMake getting confused about some parts of the code handling ATLAS_PLATFORM as a cache variable, while other parts handle it as a "normal" one.

At the same time I also simplified a bit what's happening with the BUILDNAME variable. Since that's not a variable that the base projects would influence, and just has to be in sync with ATLAS_PLATFORM at all times. So while I kept it as a cache variable, it's always forcefully set to the same value as ATLAS_PLATFORM.

The users will be able to force a build platform name on their builds using the ATLAS_FORCE_PLATFORM cache variable from here on out. Like:

~/Software/CMake/3.11.3/bin/cmake -DCMAKE_BUILD_TYPE=Debug \
   -DATLAS_PACKAGE_FILTER_FILE=../package_filters_example.txt \
   -DAtlasCMake_DIR=~/ATLAS/sw/projects/volatile/ATLINFR-2388/atlasexternals/Build/AtlasCMake \
   -DLCG_DIR=~/ATLAS/sw/projects/volatile/ATLINFR-2388/atlasexternals/Build/AtlasLCG \
   -DATLAS_FORCE_PLATFORM=x86_64-mac1013-gcc8-dbg \
   ../athena/Projects/WorkDir/

Merge request reports