Set C++17 for GCC 7 and above, in line with LCG

Hi,

Since a few people now hit the issue that their local GCC8 compilation doesn't work unless they specify CMAKE_CXX_STANDARD=17, I thought it was best to enable this for GCC 7 and above directly.

Once we drop GCC 6.2 we can remove this logic.

Work related to ATLINFR-2384

Cheers,

Stewart

And now I remembered that you'll have to also update this line:

https://gitlab.cern.ch/atlas/atlasexternals/blob/master/Build/AtlasLCG/LCGConfig.cmake#L468

That's because Gaudi doesn't rely on our specialised build flags for setting up its own thing. Hence we need to force it through AtlasLCG to use the c++ standard that we want... (Plus I wanted back in the day to make AtlasLCG functional without AtlasCMake as well.)

resolved all discussions

added 1 commit

• 3e0f4623 - Remove whitespace

Compare with previous version

added 1 commit

• 71acb3a9 - Set C++ standard also in AtlasLCG

Compare with previous version

AE Build SUCCESS
Build logfiles are available at Jenkins [AE-MERGE-REQUEST #569]

AE Build SUCCESS
Build logfiles are available at Jenkins [AE-MERGE-REQUEST #571]

AE Build SUCCESS
Build logfiles are available at Jenkins [AE-MERGE-REQUEST #572]

mentioned in commit 162b7687

merged

Hi Stewart,

Note that tag 2.0.12, which I made last evening, is currently in validation for master. (https://gitlab.cern.ch/atlas/athena/merge_requests/14843) We should probably wait for that to go through first, and then see exactly when to push this one in...

Cheers, Attila

Hi @smh, So now that this is in master I can remove the explicit -x "-DCMAKE_CXX_STANDARD=17" from the jenkins jobs right ?

No, please don't! This is far from being in the nightly yet.

First I'll need to make a 2.0.13 tag, then that will need to be picked up by the master branch of atlas/athena. Only then will this update appear in the nightly.

So no, please don't change anything just yet.

Ouu right that is in atlasexternals (overlooked that). Sure will not change anything until that gets into master athena!

I see 2.0.13 tag was made and master is now using that. Removing -x "-DCMAKE_CXX_STANDARD=17" from the jenkins jobs