Skip to content
Snippets Groups Projects

Fix FindQt5.cmake, master branch (2019.02.28.)

Unfortunately lcg_wrap_find_module(...) doesn't know how to set up the <FOO>_LIBRARY_DIRS variable when only imported targets are set up by a find-module, and no <FOO>_LIBRARIES variable is available.

So instead of using NO_LIBRARY_DIRS with lcg_wrap_find_module(...), the QT5_LIBRARY_DIRS variable is now set up by hand instead. In a more robust way than was used before, before this issue got introduced.

This problem was unfortunately only seen once I tried to update the master branch with athena!21493 (merged). :frowning:

Cc-ing @rbianchi on this as well...

Merge request reports

Pipeline #728119 passed

Pipeline passed for ce9c4dac on akraszna:FindQt5Fix-master-20190228

Approval is optional

Merged by Attila KrasznahorkayAttila Krasznahorkay 6 years ago (Feb 28, 2019 9:45am UTC)

Merge details

  • Changes merged into master with f06553d0.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading