Added support for AMD archiecture flag in HIP, since HCC is deprecated
I get a deprecation warning from hipcc 4.4 that the hcc architecture is deprecated in favour of amd.
This MR adds support for the amd flag, treating it identically to hcc
Merge request reports
Activity
- Resolved by Benjamin Michael Wynne
- Resolved by Benjamin Michael Wynne
- Resolved by Benjamin Michael Wynne
- Resolved by Benjamin Michael Wynne
Thanks a million Ben!
Sorry for the long silence. After your first message last week, I set out to update my Docker image (https://gitlab.cern.ch/akraszna/atlas-gpu-devel-env) to GCC 11, so that it could be used with our latest nightlies. But that has miserably failed so far. (It's a longer story. The Intel compiler does not like to be compiled against the "compatibility driver library" of CUDA 11 as it seems.) At which point I stepped away from this issue.
Now... We definitely need to keep this HIP code alive for a while longer. Even though CMake natively supports HIP by now (https://discourse.cmake.org/t/cmake-3-21-0-available-for-download/), it can still not build NVIDIA binaries in any convenient way as far as I can see. (https://discourse.cmake.org/t/how-to-build-nvidia-binaries-using-cmakes-new-hip-language/)
But with that said, I've not been putting any real effort into maintaining https://github.com/acts-project/vecmem/tree/main/cmake/hip recently. That code, which is a much more robust implementation of this code, was meant to be migrated back into this repository eventually. But now I've been rather waiting for CMake to implement everything that we need, and then retire the ATLAS specific HIP code completely. (Since HIP is not really a priority for HCAF at the moment, I did not really consider contributing to CMake on this...
)
mentioned in commit ec52e8ee
mentioned in merge request !1103 (merged)