Avoid self-referencing in the Phase class
The following discussion from !22 should be addressed:
-
@dlizan started a discussion: You don't have to address this, but I'm not liking
Phase
being self-referencing.I feel
next_phase_name
shouldn't be a thing (next.name
exists) andnext
shouldn't beOptional
if you're going to havePhaseManager.NO_PHASE
.In my mind there can be a separate
AnalysisPlan
class, specifying what phases to proceed with based on success/failure, so thatPhase
could be simpler and only hold name, phase law and comments attributes.