Skip to content

fix: revert scikit-build version to 0.13.1 from latest (0.14.0)

Daniel Joseph Antrim requested to merge dantrim_fix_package_data_include into devel

What

This MR fixes the failing CI pipelines in which failures during scikit-build's cmake-install step would fail.

The precise errors are (apparently) due to the package data files (specified in MANIFEST.in) being looked for in incorrect directories.

For example, here is an output failure that results from python -m pip install . (expand):

Expand 
  ...
  ...
  copying _skbuild/linux-x86_64-3.6/setuptools/lib/labRemote/src/labRemote/__init__.py -> _skbuild/linux-x86_64-3.6/setuptools/bdist.linux-x86_64/wheel/labRemote/src/labRemote
  copying _skbuild/linux-x86_64-3.6/setuptools/lib/labRemote/src/labRemote/chiller.py -> _skbuild/linux-x86_64-3.6/setuptools/bdist.linux-x86_64/wheel/labRemote/src/labRemote
  copying _skbuild/linux-x86_64-3.6/setuptools/lib/labRemote/src/labRemote/com.py -> _skbuild/linux-x86_64-3.6/setuptools/bdist.linux-x86_64/wheel/labRemote/src/labRemote
  copying _skbuild/linux-x86_64-3.6/setuptools/lib/labRemote/src/labRemote/datasink.py -> _skbuild/linux-x86_64-3.6/setuptools/bdist.linux-x86_64/wheel/labRemote/src/labRemote
  copying _skbuild/linux-x86_64-3.6/setuptools/lib/labRemote/src/labRemote/devcom.py -> _skbuild/linux-x86_64-3.6/setuptools/bdist.linux-x86_64/wheel/labRemote/src/labRemote
  copying _skbuild/linux-x86_64-3.6/setuptools/lib/labRemote/src/labRemote/ec.py -> _skbuild/linux-x86_64-3.6/setuptools/bdist.linux-x86_64/wheel/labRemote/src/labRemote
  copying _skbuild/linux-x86_64-3.6/setuptools/lib/labRemote/src/labRemote/meter.py -> _skbuild/linux-x86_64-3.6/setuptools/bdist.linux-x86_64/wheel/labRemote/src/labRemote
  copying _skbuild/linux-x86_64-3.6/setuptools/lib/labRemote/src/labRemote/ps.py -> _skbuild/linux-x86_64-3.6/setuptools/bdist.linux-x86_64/wheel/labRemote/src/labRemote
  copying _skbuild/linux-x86_64-3.6/setuptools/lib/labRemote/src/labRemote/version.py -> _skbuild/linux-x86_64-3.6/setuptools/bdist.linux-x86_64/wheel/labRemote/src/labRemote
  copied 40 files
  running install_data
  creating _skbuild/linux-x86_64-3.6/setuptools/bdist.linux-x86_64/wheel/labRemote-1.1.dev508+g41ac775.data
  creating _skbuild/linux-x86_64-3.6/setuptools/bdist.linux-x86_64/wheel/labRemote-1.1.dev508+g41ac775.data/data
  error: can't copy '_skbuild/linux-x86_64-3.6/cmake-install/setup.py': doesn't exist or not a regular file
  ----------------------------------------
  ERROR: Failed building wheel for labRemote

Note that these failures do not occur for scikit-build==0.13.1, but do occur for scikit-build==0.14.0, which is the latest and the one being pulled in during the build step based on our build system requirements defined in pyproject.toml:

[build-system]
requires = ["setuptools>=42", "wheel", "scikit-build", "cmake", "ninja", "setuptools_scm[toml]>=3.4"]

Pinning scikit-build==0.13.1 in pyproject.toml is a workaround that this MR introduces.

Related Issues

  • These issues are related to changes made to scikit-build release 0.14.0 (link), specifically the changes here.

Tagging @gstark

Edited by Daniel Joseph Antrim

Merge request reports