Skip to content
Snippets Groups Projects

changing signature of IPowerSupply according to issue#2 and propagate changes to RigolDP832 class

Merged Elisabetta Pianori requested to merge devel_issue2 into devel

I started working on addressing issue #2 (closed).

  • changed signature of IPowerSupply to clarify what each function does. Remove initialise, introduce reset.
  • added program (implemented in IPowerSupply) and checkCompatibility function
  • implemented program for Rigol class as an example
  • switch to using exceptions for error handling in IPowerSupply
  • replace example power supply programs with powersupply that supports EquipConf

Elisabetta

Edited by Karol Krizka

Merge request reports

Pipeline #1483421 passed

Pipeline passed for d7e3eba3 on devel_issue2

Approval is optional

Merged by Karol KrizkaKarol Krizka 5 years ago (Mar 12, 2020 8:17pm UTC)

Merge details

  • Changes merged into devel with 812859ed (commits were squashed).
  • Deleted the source branch.

Pipeline #1483459 passed

Pipeline passed for 812859ed on devel

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Can you make the title more descriptive? This is what will appear in the commit message once this is merged.

  • Elisabetta Pianori changed title from WIP: Addressing Issue #2 to WIP: changing signature of IPowerSupply according to issue#2 and propagate changes to RigolDP832 class

    changed title from WIP: Addressing Issue #2 to WIP: changing signature of IPowerSupply according to issue#2 and propagate changes to RigolDP832 class

  • Elisabetta Pianori changed the description

    changed the description

  • Elisabetta Pianori changed the description

    changed the description

  • added 1 commit

    • 8b011051 - remove initialise, add reset. Move program implementation to IPowerSupply.

    Compare with previous version

  • Elisabetta Pianori changed the description

    changed the description

  • added 1 commit

    • bad0595d - make program virtual member of IPowerSupply class

    Compare with previous version

  • Dear @theim @kkrizka @emladina @spagan,

    I addressed all comments by @kkrizka, and I moved the implementation of program back to IPowerSupply.

    There are few items associated with issue#2 that I didn't address, and I motivated it in the issue.

    Please, let me know if you have comments or suggestions - I'd like to merge the branch devel_issue2 to devel by early next week, and then start to migrate all PS class to inherit from IPowerSupply.

    Cheers, Elisabetta

    Edited by Elisabetta Pianori
  • mentioned in issue #3 (closed)

  • One more request, which I missed earlier as it was already part of devel. Can you change any string arguments to functions from std::string to const std::string&?

  • Also should we move to exception here?

  • Karol Krizka changed the description

    changed the description

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading