Resolve "Adapt bTagShapeSF such that it can handle different taggers"

Closes #134 (closed)

added Improvement label

requested review from @fmausolf and @mikumar

added 1 commit

• 69296f12 - Add all selections in one step

Compare with previous version

resolved all threads

added 1 commit

• a6010852 - Fix flake8 issue

Compare with previous version

resolved all threads

added 1 commit

• 4a849291 - minor change in comment

Compare with previous version

requested review from @tbevilac

Hi @nkasarag @mikumar @tbevilac,

this MR looks good to me, thanks for the work! Is there anything missing before we can merge? I can also give it a test run, if useful, just let me know.

The code changes look good to me as well, but it looks like you didn't include the download of the new tagger weights in the pull_files.py script thought, are all of these included in the same JSONs as for the DeepJet ones (so there isn't any need to pull new file)? In addition, are there PNet and ParT SFs for Run2, if not could you add a switch for this check in the function?

added 1 commit

• 280bddd6 - Exit if a particular ShapeSF is not available for the specified year

Compare with previous version

added 59 commits

• 280bddd6...9aff5431 - 58 commits from branch master
• cd4dcbdb - Merge remote-tracking branch 'origin/master' into...

Compare with previous version

Hi @tbevilac, @fmausolf, @mikumar,

Sorry for the delay. The JSONS files for Run3 SF, also includes ParticleNet and ParticleTransformer SFs. So we do not need to pull separate files for them.

Also, we do not have ParticleNet and ParticleTransformer SFs for Run2 (correct me if I am wrong). Now, the code exits with a message if a user asks for ParticleNet or ParticleTransformer SF for Run2.

Let me know if any further changes are required

Thanks @nkasarag, let's merge this MR finally...

merged

mentioned in commit 4982de22