Draft: Added rapidity branch in base workflow
Added rapidity branch in base workflow, after adding a rapidity getter in coffea (https://github.com/CoffeaTeam/coffea/pull/825) The rapidity values were checked on few MC events by re-evaluating from the root output the rapidity and comparing it with the rapidity brach values. The plot shows the histogram of the residuals between the two quantities.
Merge request reports
Activity
added Improvement label
requested review from @jspah
Thanks for this nice work. Feel free to assign me and/or Florian and Massimiliano for such simple MRs in the future. That way we get notifications immediately.
If I understand correctly,
diphoton_4mom.rapidity
will work with the current master version of coffea since https://github.com/CoffeaTeam/coffea/pull/825 has been merged. Can you confirm that made your tests with the master branch version of coffea? I would be reluctant to merge this now because we recommend installation of the new environment for HiggsDNA with conda/mamba and the latest version in conda-forge (https://anaconda.org/conda-forge/coffea) probably does not include the changes yet (Last upload: 2 months and 18 days ago).Therefore, to protect this MR from being merged preemptively, I also added a draft label. Tagging @magalli and @fmausolf for this as well, please feel free to chime in if you disagree with me.
Correct. So for the time being do you suggest to just add the function in Higgs DNA? At the end it is just a simple calculation (but we thoughts it was cleaner to put in coffea for the future). Then we replace with the coffea method when that change will be merged. Let us know if we can proceed like this
mentioned in issue #109 (closed)
mentioned in merge request !164 (merged)
We included this feature in !164 (merged). Sorry, @rgargiul and @emanuele, we forgot about this MR all those months ago from the developer side! In any case, your validation was still very helpful for us. Closing this MR