Skip to content

Rework of PedeNoise result file plotting

Younes Otarid requested to merge yotarid/Ph2_ACF:ps_module_dev into Dev

This merge request introduces a rework of the PedeNoise result file plotting. The former implementation was 2S-centred, which was leading to messy histograms in the case of PS modules (ie : histogram ranges, number of channels, etc ... are different between SSA and MPA). This new version introduces the following changes :

  • Use of ReadoutChip query functions to assign histograms to specific chips.
  • Discarding Odd/Even histogram in the case of PS module. Only included if 2S.
  • Assigning proper SCurve, Pedestal global or per-strip/pixel, Noise global or per-strip/pixel ... and other histograms, with correct ranges and entries, to strip or pixel chips.

Additional changes :

  • Extension of Tx/Rx optical link polarity configuration to all links based on lpGBT version and FMC slot
  • Minor bug fix to the SystemController that was affecting mux_setup control
  • Minor bug fix (very ugly and thus to be discussed) in the D19cTriggerInterface where the trigger FSM sometimes doesn't start and needs another push.
Edited by Younes Otarid

Merge request reports