Skip to content

Fix CI cppcheck errors

During xmas the CI fails during cppcheck due to an update on the rules and now we get the following errors during the static analysis:

        <error id="iterateByValue" severity="performance" msg="Range variable &apos;sequence&apos; should be declared as const reference." verbose="Variable &apos;sequence&apos; is used to iterate by value. It could be declared as a const reference which is usually faster and recommended in C++." cwe="398" file0="catalogue/DropSchemaCmd.cpp">
            <location file="catalogue/DropSchemaCmd.cpp" line="165" column="14" info="Range variable &apos;sequence&apos; should be declared as const reference."/>
            <symbol>sequence</symbol>
        </error>
        <error id="passedByValue" severity="performance" msg="Function parameter &apos;name&apos; should be passed by const reference." verbose="Parameter &apos;name&apos; is passed by value. It could be passed as a const reference which is usually faster and recommended in C++." cwe="398" file0="objectstore/Agent.cpp">
            <location file="objectstore/Agent.cpp" line="209" column="63" info="Function parameter &apos;name&apos; should be passed by const reference."/>
            <symbol>name</symbol>
        </error>
        <error id="passedByValue" severity="performance" msg="Function parameter &apos;name&apos; should be passed by const reference." verbose="Parameter &apos;name&apos; is passed by value. It could be passed as a const reference which is usually faster and recommended in C++." cwe="398" file0="objectstore/AgentRegister.cpp">
            <location file="objectstore/AgentRegister.cpp" line="79" column="62" info="Function parameter &apos;name&apos; should be passed by const reference."/>
            <symbol>name</symbol>
        </error>
        <error id="iterateByValue" severity="performance" msg="Range variable &apos;sequence&apos; should be declared as const reference." verbose="Variable &apos;sequence&apos; is used to iterate by value. It could be declared as a const reference which is usually faster and recommended in C++." cwe="398" file0="scheduler/PostgresSchedDB/schema/DropSchemaCmd.cpp">
            <location file="scheduler/PostgresSchedDB/schema/DropSchemaCmd.cpp" line="170" column="14" info="Range variable &apos;sequence&apos; should be declared as const reference."/>