Skip to content
Snippets Groups Projects

Resolve "Trim SQL query length in catalogue DB failure reason"

All threads resolved!

Summary

Requires manual tests in pre-production

References

Closes #250 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Joao Afonso
    • Resolved by Joao Afonso

      I think this looks good. I have just added some minor typo suggestions, which you are free to accept or ignore.

      I addition to that, are these changes supposed to cover both taped and user invocations of these catalogue functions?
      Shouldn't we still return an error to the user (which can be an operator tool) if it inserts a comment that is too long? I think this is not a problem (1000 characters is too long already), but I leave this observation to your judgement anyway.

      Edited by Joao Afonso
  • added 1 commit

    • b2fc8372 - change trimComment to trimmedComment

    Compare with previous version

  • Jorge Camarero Vera resolved all threads

    resolved all threads

  • added 1 commit

    • d871836f - Fix maximum typo and improve log message

    Compare with previous version

  • added 1 commit

    • bdd7d041 - Fix maximum typo and improve log message

    Compare with previous version

  • added 5 commits

    • a3427fc9 - 1 commit from branch main
    • 83e60dc3 - Truncate comments and reason for SQL maximum
    • d01bc14b - Update ReleaseNotes
    • 89b45675 - change trimComment to trimmedComment
    • 9fc6189e - Fix maximum typo and improve log message

    Compare with previous version

  • Joao Afonso resolved all threads

    resolved all threads

  • Joao Afonso approved this merge request

    approved this merge request

  • Jorge Camarero Vera marked this merge request as ready

    marked this merge request as ready

  • Jorge Camarero Vera enabled an automatic merge when the pipeline for 9fc6189e succeeds

    enabled an automatic merge when the pipeline for 9fc6189e succeeds

  • Joao Afonso requested review from @afonso

    requested review from @afonso

  • Joao Afonso aborted the automatic merge because target branch was updated

    aborted the automatic merge because target branch was updated

  • added 5 commits

    • 78644428 - 1 commit from branch main
    • 31864763 - Truncate comments and reason for SQL maximum
    • a48cc401 - Update ReleaseNotes
    • a7c379ea - change trimComment to trimmedComment
    • bd0541e0 - Fix maximum typo and improve log message

    Compare with previous version

  • Jorge Camarero Vera enabled an automatic merge when the pipeline for bd0541e0 succeeds

    enabled an automatic merge when the pipeline for bd0541e0 succeeds

  • Jorge Camarero Vera approved this merge request

    approved this merge request

  • Please register or sign in to reply
    Loading