From 1b000d44becbcd35a3ccfd9744d247288a952607 Mon Sep 17 00:00:00 2001
From: scott snyder <sss@karma>
Date: Wed, 7 Feb 2024 17:01:10 -0500
Subject: [PATCH] TrigConfStorage: Fix cppcheck warnings.
Copying values in range-for.
---
.../src/TrigConfCoolHLTPayloadConverters.cxx | 6 +++---
.../TrigConfStorage/src/apps/ReadWrite.cxx | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/Trigger/TrigConfiguration/TrigConfStorage/src/TrigConfCoolHLTPayloadConverters.cxx b/Trigger/TrigConfiguration/TrigConfStorage/src/TrigConfCoolHLTPayloadConverters.cxx
index 04b3dae795da..ad9b80463c9e 100644
--- a/Trigger/TrigConfiguration/TrigConfStorage/src/TrigConfCoolHLTPayloadConverters.cxx
+++ b/Trigger/TrigConfiguration/TrigConfStorage/src/TrigConfCoolHLTPayloadConverters.cxx
@@ -1,5 +1,5 @@
/*
- Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+ Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
*/
#include "TrigConfStorage/TrigConfCoolHLTPayloadConverters.h"
@@ -59,7 +59,7 @@ TrigConfCoolHLTPayloadConverters::createHltChainGroupPayload(cool::IFolderPtr fl
string groups(ch.level());
groups += ";";
bool start(true);
- for(string group : ch.groups()) {
+ for(const string& group : ch.groups()) {
if(start) { start=false; } else { groups += ","; }
groups += group;
}
@@ -229,7 +229,7 @@ TrigConfCoolHLTPayloadConverters::addGroupsToHltChain( const coral::AttributeLis
vector<string> grV = split(lvlGrp[1],",");
for(HLTChain* ch : chl) {
if( ch->chain_counter()==cc && ch->level()==level) {
- for(string gr : grV) ch->addGroup(gr);
+ for(const string& gr : grV) ch->addGroup(gr);
break;
}
}
diff --git a/Trigger/TrigConfiguration/TrigConfStorage/src/apps/ReadWrite.cxx b/Trigger/TrigConfiguration/TrigConfStorage/src/apps/ReadWrite.cxx
index 0ab783126d09..26265d34a564 100644
--- a/Trigger/TrigConfiguration/TrigConfStorage/src/apps/ReadWrite.cxx
+++ b/Trigger/TrigConfiguration/TrigConfStorage/src/apps/ReadWrite.cxx
@@ -1,5 +1,5 @@
/*
- Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration
+ Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
*/
/////////////////////////////////////////////////////////////////////
@@ -328,11 +328,11 @@ JobConfig::PrintSetup(std::ostream & log, std::ostream& (*lineend) ( std::ostrea
log << lineend;
log << "----------" << lineend;
log << " Input : ";
- for(string s: inpar) log << s << ", ";
+ for(const string& s: inpar) log << s << ", ";
log << lineend;
if( input2 != UNDEF ) {
log << " Input for comparison: ";
- for(string s: inpar2) log << s << ", ";
+ for(const string& s: inpar2) log << s << ", ";
log << lineend;
}
if( output != UNDEF ) {
--
GitLab