diff --git a/Control/StoreGate/StoreGate/ReadHandle.icc b/Control/StoreGate/StoreGate/ReadHandle.icc index 6344f0d9ce494d6576f9a7a1392d471154faa5a8..504d37a66ba9628a4574aef07e16c32b3d948a5d 100644 --- a/Control/StoreGate/StoreGate/ReadHandle.icc +++ b/Control/StoreGate/StoreGate/ReadHandle.icc @@ -1,8 +1,6 @@ /* - Copyright (C) 2002-2018 CERN for the benefit of the ATLAS collaboration + Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration */ - -// $Id: ReadHandle.icc 797637 2017-02-17 02:32:11Z ssnyder $ /** * @file StoreGate/ReadHandle.icc * @author S. Binet, P. Calafiura, scott snyder <snyder@bnl.gov> @@ -280,6 +278,7 @@ inline ReadHandle<T>::ReadHandle (const VarHandleKey& key, const EventContext* ctx) : VarHandleBase (key, ctx) { + // cppcheck-suppress missingReturn; false positive } diff --git a/Control/StoreGate/StoreGate/WriteHandle.icc b/Control/StoreGate/StoreGate/WriteHandle.icc index f79836d1643703e70b7f322601563ced7a1b4a87..6e9a991aa189bd7c9e4f8b31ddedf81889f288db 100644 --- a/Control/StoreGate/StoreGate/WriteHandle.icc +++ b/Control/StoreGate/StoreGate/WriteHandle.icc @@ -1,8 +1,6 @@ /* - Copyright (C) 2002-2023 CERN for the benefit of the ATLAS collaboration + Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration */ - -// $Id: WriteHandle.icc 797637 2017-02-17 02:32:11Z ssnyder $ /** * @file StoreGate/WriteHandle.icc * @author S. Binet, P. Calafiura, scott snyder <snyder@bnl.gov> @@ -88,6 +86,7 @@ WriteHandle<T>::WriteHandle (const WriteHandleKey<T>& key, const EventContext& ctx) : VarHandleBase (key, &ctx) { + // cppcheck-suppress missingReturn; false positive } diff --git a/Control/StoreGate/src/SGImplSvc.cxx b/Control/StoreGate/src/SGImplSvc.cxx index 5b43ed7edd35188a4b8035cc5540e1cb40bc5158..5c3987eccd4844979adbcf31bce87206e7929694 100644 --- a/Control/StoreGate/src/SGImplSvc.cxx +++ b/Control/StoreGate/src/SGImplSvc.cxx @@ -1,5 +1,5 @@ /* - Copyright (C) 2002-2023 CERN for the benefit of the ATLAS collaboration + Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration */ #include <algorithm> @@ -1896,7 +1896,7 @@ StatusCode SGImplSvc::retrieve (CLID clid, { lock_t lock (m_mutex); SG::ConstProxyIterator first; - SG::ConstProxyIterator end = first; + SG::ConstProxyIterator end; if (!(proxyRange(clid,first,end)).isSuccess()) { std::string typnam; diff --git a/Control/StoreGate/test/DataHandle_test.cxx b/Control/StoreGate/test/DataHandle_test.cxx index e87aabcc07e26243d362721b344b84e94ef735c2..62f6f47561b370c1a975d038504014c6e828c7f7 100644 --- a/Control/StoreGate/test/DataHandle_test.cxx +++ b/Control/StoreGate/test/DataHandle_test.cxx @@ -1,5 +1,5 @@ /* - Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration + Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration */ // DataHandle<> is not thread-safe. @@ -174,7 +174,7 @@ namespace Athena_test { assert (vp[3]->refCount() == 1); for (int i=0; i < 3; i++) assert (vp[i]->refCount() == 2); - it++; it++; + ++it; ++it; assert (dh.setState (it, mp.end()).isSuccess()); assert (vp[0]->refCount() == 1); assert (vp[1]->refCount() == 2); diff --git a/Control/StoreGate/test/SGtests.cxx b/Control/StoreGate/test/SGtests.cxx index e4b1e84b7c7b34c93f80969c067cd266e2c6e8d2..1ceee0d7159a3954db7cdd9e51445d9b818fffd2 100644 --- a/Control/StoreGate/test/SGtests.cxx +++ b/Control/StoreGate/test/SGtests.cxx @@ -1,5 +1,5 @@ /* - Copyright (C) 2002-2023 CERN for the benefit of the ATLAS collaboration + Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration */ /*************************************************************************** @@ -778,6 +778,7 @@ namespace Athena_test { rSG.clearStore(true).ignore(); rSG.clearStore().ignore(); + // cppcheck-suppress memleak; pBar not really leaked } void testTransientSwap(::StoreGateSvc& rSG)