Merge branch 'ProduceSegments' into 'main'

Set ITkRotCreatorCfg as a private tool instead of public to avoid inconsistencies with multiple tracking passes configuration

See merge request atlas/athena!70972

InnerDetector/InDetConfig/python/SeedToTrackConversionToolConfig.py

@@ -43,9 +43,7 @@ def ITkSeedToTrackConversionToolCfg(
 
     if "RIO_OnTrackCreator" not in kwargs:
         from TrkConfig.TrkRIO_OnTrackCreatorConfig import ITkRotCreatorCfg
-        RotCreator = acc.popToolsAndMerge(ITkRotCreatorCfg(flags))
-        acc.addPublicTool(RotCreator)
-        kwargs.setdefault("RIO_OnTrackCreator", RotCreator)
+        kwargs.setdefault("RIO_OnTrackCreator", acc.popToolsAndMerge(ITkRotCreatorCfg(flags)))
 
     extension = flags.Tracking.ActiveConfig.extension
     if extension == flags.Tracking.PrimaryPassConfig.value:

InnerDetector/InDetRecTools/SeedToTrackConversionTool/SeedToTrackConversionTool/SeedToTrackConversionTool.h

@@ -84,7 +84,7 @@ namespace InDet
     //@{
     PublicToolHandle<Trk::IExtrapolator> m_extrapolator
       {this, "Extrapolator","Trk::Extrapolator", "extrapolator"};
-    PublicToolHandle<Trk::IRIO_OnTrackCreator > m_rotcreator
+    ToolHandle<Trk::IRIO_OnTrackCreator > m_rotcreator
       {this, "RIO_OnTrackCreator", "Trk::RIO_OnTrackCreator/InDetRotCreator", "Creator ROT"};
     //@}