Merge branch '20240320e' into 'main'

Reduce the usage of signal_process_vertex and signal_process_id

See merge request atlas/athena!70000

Event/xAOD/xAODTruthCnv/src/HepMCTruthReader.cxx

@@ -54,15 +54,6 @@ StatusCode HepMCTruthReader::execute(const EventContext& ctx) const {
     // Print the event particle/vtx contents
     if (cntr==0) ATH_MSG_INFO("Printing signal event...");
     if (cntr>0) ATH_MSG_INFO("Printing pileup events...");  
-
-    if (cntr==0) {
-      auto signalProcessVtx = HepMC::signal_process_vertex(genEvt);
-      ATH_MSG_INFO("Signal process vertex position: (" << (signalProcessVtx?signalProcessVtx->position().x():0)
-		   << ", " << (signalProcessVtx?signalProcessVtx->position().y():0)
-           << ", " << (signalProcessVtx?signalProcessVtx->position().z():0)
-           << "). Pointer: " << signalProcessVtx);
-    }
-
     printEvent(genEvt, m_do4momPtEtaPhi);
 
   }

Event/xAOD/xAODTruthCnv/src/xAODTruthCnvAlg.cxx

@@ -360,13 +360,7 @@ namespace xAODMaker {
           // If this is a disconnected vertex, add it manually or won't be added from the loop over particles below.
            auto disconnectedSignalProcessVtx = HepMC::signal_process_vertex(genEvt); // Get the signal process vertex
           if (disconnectedSignalProcessVtx) {
-#ifdef HEPMC3
-            if (disconnectedSignalProcessVtx->particles_in().empty() &&
-                disconnectedSignalProcessVtx->particles_out().empty() ) {
-#else
-            if (disconnectedSignalProcessVtx->particles_in_size() == 0 &&
-                disconnectedSignalProcessVtx->particles_out_size() == 0 ) {
-#endif
+            if (disconnectedSignalProcessVtx->particles_in_size() == 0 && disconnectedSignalProcessVtx->particles_out_size() == 0 ) {
               //This is a disconnected vertex, add it manually
               vertices.push_back (disconnectedSignalProcessVtx);
             }

Generators/GeneratorFilters/src/DirectPhotonFilter.cxx

@@ -59,7 +59,6 @@ StatusCode DirectPhotonFilter::filterEvent() {
 
   int phot = 0;
   for(const HepMC::GenEvent* genEvt : *events_const()) {
-    ATH_MSG_DEBUG("----->>> Process : " << HepMC::signal_process_id(genEvt));
     // Find all prompt photons with within given eta range
     for (const auto& pitr: *genEvt) {
       if (MC::isPhoton(pitr) &&

Generators/Starlight_i/src/Starlight_i.cxx

@@ -149,9 +149,6 @@ Starlight_i::fillEvt(HepMC::GenEvent* evt)
     // Set the event number
     evt->set_event_number( m_events );
 
-    // Set the generator id
-    HepMC::set_signal_process_id(evt,0);
-
     // Create the event vertex
     HepMC::GenVertexPtr v1 = HepMC::newGenVertexPtr();
     evt->add_vertex( v1 );