Merge branch 'cppcheck.TrigConfStorage-20240301' into 'main'

TrigConfStorage: Fix cppcheck warnings.

See merge request atlas/athena!69427

Trigger/TrigConfiguration/TrigConfStorage/src/TrigConfCoolHLTPayloadConverters.cxx

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
 */
 
 #include "TrigConfStorage/TrigConfCoolHLTPayloadConverters.h"
@@ -59,7 +59,7 @@ TrigConfCoolHLTPayloadConverters::createHltChainGroupPayload(cool::IFolderPtr fl
    string groups(ch.level());
    groups += ";";
    bool start(true);
-   for(string group : ch.groups()) {
+   for(const string& group : ch.groups()) {
       if(start) { start=false; } else { groups += ","; }
       groups += group;
    }
@@ -229,7 +229,7 @@ TrigConfCoolHLTPayloadConverters::addGroupsToHltChain( const coral::AttributeLis
       vector<string> grV = split(lvlGrp[1],",");
       for(HLTChain* ch : chl) {
          if( ch->chain_counter()==cc && ch->level()==level) {
-            for(string gr : grV) ch->addGroup(gr);
+            for(const string& gr : grV) ch->addGroup(gr);
             break;
          }
       }

Trigger/TrigConfiguration/TrigConfStorage/src/apps/ReadWrite.cxx

 /*
-  Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
 */
 
 /////////////////////////////////////////////////////////////////////
@@ -328,11 +328,11 @@ JobConfig::PrintSetup(std::ostream & log, std::ostream& (*lineend) ( std::ostrea
    log << lineend;
    log << "----------" << lineend;
    log << "   Input               : ";
-   for(string s: inpar) log << s << ", ";
+   for(const string& s: inpar) log << s << ", ";
    log << lineend;
    if( input2 != UNDEF ) {
       log << "   Input for comparison: ";
-      for(string s: inpar2) log << s << ", ";
+      for(const string& s: inpar2) log << s << ", ";
       log << lineend;
    }
    if( output != UNDEF ) {