Merge branch 'Surface_uniqueClone_avoid_hide' into 'master'

Trk::Surfaces for now avoid hiding the uniqueClone

See merge request atlas/athena!59009

Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/ConeSurface.h

@@ -104,8 +104,6 @@ public:
   /**Implicit Constructor*/
   virtual ConeSurface* clone() const override;
   
-  std::unique_ptr<ConeSurface> uniqueClone() const;
-
   /** Use the Surface as a ParametersBase constructor, from local parameters -
    * charged */
   virtual Surface::ChargedTrackParametersUniquePtr createUniqueTrackParameters(

Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/ConeSurface.icc

@@ -47,12 +47,6 @@ ConeSurface::clone() const
   return new ConeSurface(*this);
 }
 
-inline std::unique_ptr<ConeSurface> 
-ConeSurface::uniqueClone() const{
-  return std::unique_ptr<ConeSurface>(clone());
-}
-
-
 inline Amg::Vector3D
 ConeSurface::normal(const Amg::Vector2D& lp) const
 {

Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/CylinderSurface.h

@@ -120,7 +120,6 @@ public:
   /**Implicit Constructor*/
   virtual CylinderSurface* clone() const override;
   
-  std::unique_ptr<CylinderSurface> uniqueClone() const;
   /** Use the Surface as a ParametersBase constructor, from local parameters -
    * charged */
   virtual Surface::ChargedTrackParametersUniquePtr createUniqueTrackParameters(

Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/CylinderSurface.icc

@@ -49,11 +49,6 @@ CylinderSurface::clone() const
   return new CylinderSurface(*this);
 }
 
-inline std::unique_ptr<CylinderSurface> 
-CylinderSurface::uniqueClone() const{
-  return std::unique_ptr<CylinderSurface>(clone());
-}
-
 inline Amg::Vector3D
 CylinderSurface::normal(const Amg::Vector2D& lp) const
 {

Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/DiscSurface.h

@@ -139,8 +139,6 @@ public:
   /** Virtual constructor*/
   virtual DiscSurface* clone() const override;
   
-  std::unique_ptr<DiscSurface>uniqueClone() const;
-
   /** Use the Surface as a ParametersBase constructor, from local parameters -
    * charged */
   virtual Surface::ChargedTrackParametersUniquePtr createUniqueTrackParameters(

Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/DiscSurface.icc

@@ -46,11 +46,6 @@ DiscSurface::clone() const
   return new DiscSurface(*this);
 }
 
-inline std::unique_ptr<DiscSurface>
-DiscSurface::uniqueClone() const{
-  return std::unique_ptr<DiscSurface>(clone());
-}
-
 inline const SurfaceBounds&
 DiscSurface::bounds() const
 {

Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/PerigeeSurface.h

@@ -76,9 +76,6 @@ public:
   /**Virtual constructor*/
   virtual PerigeeSurface* clone() const override final;
   
-  /** NVI unique_ptr method **/
-  std::unique_ptr<PerigeeSurface> uniqueClone() const;
-
   /**Equality operator*/
   virtual bool operator==(const Surface& sf) const override;
 

Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/PerigeeSurface.icc

@@ -48,11 +48,6 @@ PerigeeSurface::clone() const
   return new PerigeeSurface(*this);
 }
 
-inline std::unique_ptr<PerigeeSurface> 
-PerigeeSurface::uniqueClone() const{
-  return std::unique_ptr<PerigeeSurface>(clone());
-}
-
 inline const Amg::Vector3D&
 PerigeeSurface::normal() const
 {

Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/PlaneSurface.h

@@ -162,9 +162,6 @@ public:
   /**Virtual constructor*/
   virtual PlaneSurface* clone() const override;
   
-   /** NVI uniqueClone method */
-  std::unique_ptr<PlaneSurface>uniqueClone() const;
-
   /** Return the surface type */
   virtual SurfaceType type() const override final;
 

Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/PlaneSurface.icc

@@ -54,11 +54,6 @@ PlaneSurface::clone() const
   return new PlaneSurface(*this);
 }
 
-inline std::unique_ptr<PlaneSurface>
-PlaneSurface::uniqueClone() const{
-  return std::unique_ptr<PlaneSurface>(clone());
-}
-
 inline bool
 PlaneSurface::insideBounds(const Amg::Vector2D& locpos,
                            double tol1,

Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/StraightLineSurface.h

@@ -95,9 +95,6 @@ public:
   /** Implicit constructor*/
   virtual StraightLineSurface* clone() const override final;
   
-  /** NVI uniqueClone **/
-  std::unique_ptr<StraightLineSurface> uniqueClone() const;
-
   /** Use the Surface as a ParametersBase constructor, from local parameters -
    * charged */
   virtual Surface::ChargedTrackParametersUniquePtr createUniqueTrackParameters(

Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/StraightLineSurface.icc

@@ -48,11 +48,6 @@ StraightLineSurface::clone() const
   return new StraightLineSurface(*this);
 }
 
-inline std::unique_ptr<StraightLineSurface> 
-StraightLineSurface::uniqueClone() const{
-  return std::unique_ptr<StraightLineSurface>(clone());
-}
-
 inline const SurfaceBounds&
 StraightLineSurface::bounds() const
 {