diff --git a/Simulation/ISF/ISF_FastCaloSim/ISF_PunchThroughTools/src/PDFcreator.h b/Simulation/ISF/ISF_FastCaloSim/ISF_PunchThroughTools/src/PDFcreator.h index d014024e11103f9676096feded788f9a05ceae80..b58168d0eb593cb1444d07aa19e17a6062a7f47b 100644 --- a/Simulation/ISF/ISF_FastCaloSim/ISF_PunchThroughTools/src/PDFcreator.h +++ b/Simulation/ISF/ISF_FastCaloSim/ISF_PunchThroughTools/src/PDFcreator.h @@ -1,5 +1,5 @@ /* - Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration + Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration */ /////////////////////////////////////////////////////////////////// @@ -48,7 +48,7 @@ namespace ISF /** get the random value with this method, by providing the input parameters */ double getRand(CLHEP::HepRandomEngine* rndmEngine, const std::vector<int>& inputParameters) const; - std::string getName() const {return m_name;}; + const std::string& getName() const {return m_name;}; private: std::string m_name; //!< Give pdf a name for debug purposes diff --git a/Simulation/ISF/ISF_FastCaloSim/ISF_PunchThroughTools/src/PunchThroughTool.cxx b/Simulation/ISF/ISF_FastCaloSim/ISF_PunchThroughTools/src/PunchThroughTool.cxx index d6ceb2fec51c382d465bccf06dc9a4d87f97f3cf..93c9b1ec79f15f325be5d91e36af0014dc0d190b 100644 --- a/Simulation/ISF/ISF_FastCaloSim/ISF_PunchThroughTools/src/PunchThroughTool.cxx +++ b/Simulation/ISF/ISF_FastCaloSim/ISF_PunchThroughTools/src/PunchThroughTool.cxx @@ -966,7 +966,7 @@ std::map<double, double> ISF::PunchThroughTool::getVariableCDFmappings(xmlNodePt return mappings; } -double ISF::PunchThroughTool::inverseCdfTransform(double variable, std::map<double, double> inverse_cdf_map) { +double ISF::PunchThroughTool::inverseCdfTransform(double variable, const std::map<double, double>& inverse_cdf_map) { double norm_cdf = normal_cdf(variable); diff --git a/Simulation/ISF/ISF_FastCaloSim/ISF_PunchThroughTools/src/PunchThroughTool.h b/Simulation/ISF/ISF_FastCaloSim/ISF_PunchThroughTools/src/PunchThroughTool.h index 16a29fb731630f040297c7cba38297dfdf18979a..fea35697a20b92fe62b319f177a7e28b461df785 100644 --- a/Simulation/ISF/ISF_FastCaloSim/ISF_PunchThroughTools/src/PunchThroughTool.h +++ b/Simulation/ISF/ISF_FastCaloSim/ISF_PunchThroughTools/src/PunchThroughTool.h @@ -115,7 +115,7 @@ namespace ISF { std::vector<double> inversePCA(int pcaCdfIterator, std::vector<double> &variables) const; //apply the inverse CDF trainsform - static double inverseCdfTransform(double variable, std::map<double, double> inverse_cdf_map) ; + static double inverseCdfTransform(double variable, const std::map<double, double>& inverse_cdf_map) ; //dot product between matrix and vector, used to inverse PCA static std::vector<double> dotProduct(const std::vector<std::vector<double>> &m, const std::vector<double> &v) ;