Paul Thompson authored 1 year ago and John Kenneth Anders committed 1 year ago

revert to AntiKt10LCTopoJets whilst the issue of large R jets in the reconstruction/monitoring is dealt with

Alaettin Serhan Mete authored 1 year ago and John Kenneth Anders committed 1 year ago

InDetSecVtxFinder + DerivationFrameworkHiggs + TrigT1CaloByteStream: Fix xAOD namespace typos

- /PhysicsAnalysis/DerivationFramework/DerivationFrameworkART/DerivationFrameworkFlavourTagART/test/test_data18FTAG1.sh
- /PhysicsAnalysis/DerivationFramework/DerivationFrameworkART/DerivationFrameworkFlavourTagART/test/test_data18FTAG2.sh
- /PhysicsAnalysis/DerivationFramework/DerivationFrameworkART/DerivationFrameworkFlavourTagART/test/test_data18FTAG3.sh
- /PhysicsAnalysis/DerivationFramework/DerivationFrameworkART/DerivationFrameworkFlavourTagART/test/test_data22FTAG1.sh
- /PhysicsAnalysis/DerivationFramework/DerivationFrameworkART/DerivationFrameworkFlavourTagART/test/test_data22FTAG2.sh
- /PhysicsAnalysis/DerivationFramework/DerivationFrameworkART/DerivationFrameworkFlavourTagART/test/test_data22FTAG3.sh
- /PhysicsAnalysis/DerivationFramework/DerivationFrameworkART/DerivationFrameworkFlavourTagART/test/test_mc20FTAG1.sh
- /PhysicsAnalysis/DerivationFramework/DerivationFrameworkART/DerivationFrameworkFlavourTagART/test/test_mc20FTAG2.sh
- /PhysicsAnalysis/DerivationFramework/DerivationFrameworkART/DerivationFrameworkFlavourTagART/test/test_mc20FTAG3.sh
- /PhysicsAnalysis/DerivationFramework/DerivationFrameworkART/DerivationFrameworkFlavourTagART/test/test_mc21FTAG1.sh
- /PhysicsAnalysis/DerivationFramework/DerivationFrameworkART/DerivationFrameworkFlavourTagART/test/test_mc21FTAG2.sh
- /PhysicsAnalysis/DerivationFramework/DerivationFrameworkART/DerivationFrameworkFlavourTagART/test/test_mc21FTAG3.sh

Multiple components apply xAOD decorations named isSplit. Since a
single type is registered for each decoration all components must use
the same type for identically named decorations. This patch ensures
that PixelCluster_v1, PixelPrepDataToxAOD, PixelNtupleMaker use the
same type.

Remove the global `ConfigFlags` instance and the safe-guards to delete
the instance manually from the various skeletons and drivers.

James Catmore authored 1 year ago and Ahmed Tarek committed 1 year ago

Removal of legacy DAOD configuration part 6

ATLASG-2592

This MR removes residual legacy DAOD configuration files, mostly things that are hiding in the python directories. All of these job options depend on content that has been deleted in previous MRs and so are now completely broken and obsolete.

Thomas Strebler authored 1 year ago and Ahmed Tarek committed 1 year ago

Clean up legacy configs in DerivationFrameworkJetEtMiss + JetJvtEfficiency

James Catmore authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

Removal of legacy config for DAOD production - part 4

This MR removes much of the legacy DAOD-making configuration code, such that the old-style reductionConf argument to Reco_tf will no longer work.

Some of the packages touched here may be completely obsolete and so more deletion may be possible, but for this MR the changes are restricted to DAOD building.

Philipp Gadow authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

MUON5 derivation: add photon slimming, remove obsolete muon content, add close-by isolation variables

David Reikher authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

[ATR-28687] eFEX Tau algorithm switch and new EDM naming convention for L1 tau RoIs

Marco Vanadia authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

Adding tighter skimming to MUON5

Laura Elaine Bruce authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

(DAOD LLP1) Add Run 3 displaced jet triggers

Maximilian Emanuel Goblirsch-Kolb authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

Upgrade-related tweaks to MUON5

James Catmore authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

Removal of legacy DAOD config - part 2

ATLASG-2592
ATLASG-2593
ATLASG-2594
ATLASG-2595
ATLASG-2596
ATLASG-2597
ATLASG-2598
ATLASG-2599

This MR removes specific obsolete legacy job options for DAOD formats. In some cases they have been replaced with CA versions, in other cases not. Those which are still needed will have to be migrated at a later date. Many will not need to be replaced due to the transition to the new analysis model (PHYS/PHYSLITE)

Laura Elaine Bruce authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

(DAOD LLP1) Add patternRecoInfo to list of track variables

This MR drops legacy config job options from DerivationFrameworkL1Calo and DerivationFrameworkTop, having confirmed that they are no longer in use

Dan Guest authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

Remove track selection string in FTAG2

James Catmore authored 1 year ago and Tadej Novak committed 1 year ago

Removal of legacy DAOD config - part 1

This is the first of several MRs to remove the legacy DAOD config from
main before the 24.0 branch. This is an initial "probe" to check that
there are no remaining tests in CI or ART dependent on the legacy. It
removes the two key files that all legacy DAOD jobs need (one for the
configuration itself and one to provide the paths to the individual job
options). Any legacy DAOD job will crash without these files.

If this passes CI I suggest we merge and then inspect the DAOD ART
tests. This will allow us to see quickly if we have any important legacy tests
remaining. Once we're happy with the state of things we can remove the rest of the legacy code,
which can be expected to be several dozen files.

Antonio Giannini authored 1 year ago and Tadej Novak committed 1 year ago

Low-Level Jet (LLJ1) new derivation format

Dan Guest authored 1 year ago and Tadej Novak committed 1 year ago

Update b-tagging variables in PHYSLITE

Scott Snyder authored 1 year ago and Tadej Novak committed 1 year ago

DerivationFrameworkMCTruth: Fix cppcheck warnings.

Pass containers by const reference, not by value.

R D Schaffer authored 1 year ago and Tadej Novak committed 1 year ago

fix for missing decorations in PHYS

Maximilian Emanuel Goblirsch-Kolb authored 1 year ago and Adam Edward Barton committed 1 year ago

Fixes to MUON5 for Upgrade samples

Thomas Strebler authored 1 year ago and Adam Edward Barton committed 1 year ago

Added ITk configs for GSF TrackStateOnSurfaceDecorator

Ondrej Kovanda authored 1 year ago and Adam Edward Barton committed 1 year ago

DerivationFramework: Addition of UTT chains to TRIG8

Stylianos Angelidakis authored 1 year ago and Adam Edward Barton committed 1 year ago

Updates for DAOD_MUON1

Follow-up to Gaudi v38 update (!66880) for properties that changed from
`list` to `set`. Assign values as `set` instead of relying on the
implicit conversion.

Thomas Strebler authored 1 year ago and Johannes Elmsheuser committed 1 year ago

Move list of IDTIDE excluded auxdata in IDTIDE config

Johannes Junggeburth authored 1 year ago and Johannes Elmsheuser committed 1 year ago

DerivationFrameworkMuons -  Fix Muon5

Zach Marshall authored 1 year ago and Johannes Elmsheuser committed 1 year ago

Fixing recursion issue in TruthDecayCollectionMaker

Under certain circumstances, some decays will be created with loops in
the particle records in the decays of BSM particles. It's a bit unusual,
but when that happens there can be an infinite recursion induced in the
truth decay collection maker, because the unique ID (previously:
barcode) isn't set until after the decay vertex and outgoing particles
are added to the record. That means if for some reason we have a vertex
that loops back on itself, the particle could be added recursively and
infinitely... until we get a stack overflow and crash (thanks to Serhan
for the tip there). Reported by Laura Bruce. Should be fixed here.

Thomas Strebler authored 1 year ago and Johannes Elmsheuser committed 1 year ago

Introduced ResidualPullCalculator CA config

Samuel Van Stroud authored 1 year ago and Johannes Elmsheuser committed 1 year ago

FTAG: Python config cleanup

Ligang Xia authored 1 year ago and Walter Lampl committed 1 year ago

Add AntiKt4UFOCSSKJets to FTAG1