Skip to content
Snippets Groups Projects
  1. Jan 30, 2024
  2. Jan 26, 2024
  3. Jan 25, 2024
    • Johannes Junggeburth's avatar
      DerivationFrameworkMuons - Fix Muon5 · b3d73abb
      Johannes Junggeburth authored and Johannes Elmsheuser's avatar Johannes Elmsheuser committed
      DerivationFrameworkMuons -  Fix Muon5
      b3d73abb
    • Zach Marshall's avatar
      Fixing recursion issue in TruthDecayCollectionMaker · 450a2f72
      Zach Marshall authored and Johannes Elmsheuser's avatar Johannes Elmsheuser committed
      Fixing recursion issue in TruthDecayCollectionMaker
      
      Under certain circumstances, some decays will be created with loops in
      the particle records in the decays of BSM particles. It's a bit unusual,
      but when that happens there can be an infinite recursion induced in the
      truth decay collection maker, because the unique ID (previously:
      barcode) isn't set until after the decay vertex and outgoing particles
      are added to the record. That means if for some reason we have a vertex
      that loops back on itself, the particle could be added recursively and
      infinitely... until we get a stack overflow and crash (thanks to Serhan
      for the tip there). Reported by Laura Bruce. Should be fixed here.
      450a2f72
  4. Jan 23, 2024
  5. Jan 16, 2024
  6. Jan 10, 2024
  7. Jan 09, 2024
  8. Jan 05, 2024
  9. Dec 22, 2023
  10. Dec 21, 2023
    • Joseph Earl Lambert's avatar
      Replace ConfigFactory used in block config with backend for text config so both are consistent. · 5b0e0364
      Joseph Earl Lambert authored and Frank Winklmeier's avatar Frank Winklmeier committed
      Default blocks are added by default. PRW parameters are obtained from ConfigAccumulator.
      
      Add autoconfigFlags as an attribute to the ConfigAccumulator so information can be
      obtained in other blocks.
      
      Update the PileupReweighting block so that campaign, input files, and useDefaultConfig
      can be obtained from autoconfigFlags. The wrapper function that handeled this before has
      been removed.
      
      addDefaultAlgs function is now part of the ConfigFactory class and is called
      automatically when initializing an object instance. Default parameters are now
      obtained from ConfigAccumulator except for noSystematics flag so that this can
      be changed from the command line if not specified directly.
      5b0e0364
  11. Dec 20, 2023
  12. Dec 19, 2023
    • Bertrand Martin Dit Latour's avatar
      DerivationFrameworkMCTruth: keep all daughters of TruthTausWithDecayParticles · 9d85a39b
      Bertrand Martin Dit Latour authored and Frank Winklmeier's avatar Frank Winklmeier committed
      DerivationFrameworkMCTruth: keep all daughters of TruthTausWithDecayParticles
      
      Hello,
      
      This MR changes the number of generations of daughter particles retained when building the TruthTausWithDecayParticles/TruthTausWithDecayVertices collections.
      It was previously set to 1, but this can lead to pathological situations, e.g. when the truth tau decays to kaons: if we don't know what the kaon decays to, we cannot properly compute the truth visible tau momentum.
      When set to -1, we retain all generations, and this seems to fix the problem.
      
       A priori, we can now recompute the various decorations of TruthTaus using TruthTausWithDecayParticles/TruthTausWithDecayVertices, such as `pt/eta/phi/m_vis`, the number of neutral/charged pions, ...
      We will need to rework a bit BuildTruthTaus to do this.
      The only variables we don't seem to get is `polarizationPhi` and `polarizationTheta` decorations, they exist for TruthTaus but not TruthTausWithDecayParticles, however these seem to always be 0.
      We still need to check we can rerun photon dressing for TruthTausWithDecayParticles.
      
      Marking as urgent as we'd need this for the upcoming DAOD_PHYS production that is imminent.
      
      Cheers,
      Bertrand
      9d85a39b
    • R D Schaffer's avatar
      added back in call to CloseBy correction which was accidentally removed in MR 67455 · 6c025309
      R D Schaffer authored and Frank Winklmeier's avatar Frank Winklmeier committed
      added back in call to CloseBy correction which was accidentally removed in MR 67455
      6c025309
  13. Dec 18, 2023
  14. Dec 15, 2023
  15. Dec 14, 2023
  16. Dec 13, 2023
  17. Dec 12, 2023
  18. Dec 11, 2023
  19. Dec 08, 2023
  20. Dec 07, 2023
    • Adrian Berrocal Guardia's avatar
      HF Classifier Package. · fa686373
      Adrian Berrocal Guardia authored and Edward Moyse's avatar Edward Moyse committed
      Cleaning of HadronOriginClassifier code.
      
      During the implementaiton of the HF classification, the code of
      HadronOriginClassifier was modified to find a bug in it. Most of this
      modifications were comments and prints to find the bug and they have
      been removed now that is fixed.
      fa686373
    • Marco Vanadia's avatar
      first test of using LeptonTaggers in MUON5 · 4e85cca1
      Marco Vanadia authored and Edward Moyse's avatar Edward Moyse committed
      Convert r21 decorators to const Accessor for vertex fits
      
      Previously, secondary vertex decoration was done using a syntax like
      
      (*decorator)(*vertex) = value;
      
      This has been changed in two places to use a const Accessor, as this
      makes the logic of the decoration more obvious and might avoid some
      subtle bugs with decoration. This was an attempt to resolve a warning
      
      WARNING saveSecondaryVertices - missing "SecondaryVertexIndex" variable
      
      but this change does not seem to fix the problem.
      4e85cca1
Loading