Johannes Junggeburth authored 10 months ago and Tadej Novak committed 10 months ago

MuonGeoModelR4 - Convert new sTgc readout elements into their legacy version

Initial sequences suport for CA-based event generation

See merge request atlas/athena!70700

TrigTransform: fix failure when running in CA-mode

Closes ATR-29357

See merge request atlas/athena!71330

Add phi extension to Phase-2 Muon pattern recognition and clean up / document existing steps

See merge request atlas/athena!71287

Maximilian Emanuel Goblirsch-Kolb authored 10 months ago and Tadej Novak committed 10 months ago

Add phi extension to Phase-2 Muon pattern recognition and clean up / document existing steps

Simplification for truth record functions

See merge request atlas/athena!71049

Andrii Verbytskyi authored 10 months ago and Tadej Novak committed 10 months ago

Simplification for truth record functions

After !71207, the transform code no longer appends an explicit `--CA` to
the athena command line.

Closes ATR-29357.

xAODCore+xAODTrigger: New method for registering auxiliary variables.

See merge request atlas/athena!71043

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

xAODCore: New method for registering auxiliary variables.

Introduce new macro AUXVAR_DECL to declare an auxiliary variable.
Can use like:

class FooAuxContainer : public AuxContainerBase
{
...
private:
  AUXVAR_DECL (int, intVar);

Nothing is required in the constructor.

An alternate allocator for the vector (if it exists) may be passed
as an extra argument:

  AUXVAR_DECL (int, intVar, std::pmr::polymorphic_allocator);

In this case, the allocator for this variable will be initialized
with the memory resource passed to the AuxContainerBase constructor.

This allows specifying the container type to use in one place.
This style of declaration will also be needed for linked variables,
such as packed links and jagged vectors.

MuonReadoutGeometryR4: Speed up MdtTubeLayer::getTubeNode().

See merge request atlas/athena!71295

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

MuonReadoutGeometryR4: Speed up MdtTubeLayer::getTubeNode().

This was using getChildVol.  However, that keeps track of the transform
to each child, even though that is not actually used.
This is slow, especially in debug builds where Eigen operations
tend to be expensive.

Instead, use GeoVisitVolumes to iterate over children without calculating
the transforms.

StoreGate: Add ReadDecorHandle::withDefault.

See merge request atlas/athena!71297

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

StoreGate: Add ReadDecorHandle::withDefault.

Add withDefault() method to ReadDecorHandle.  This works like operator(),
except that one specifies a default value to return if the variable
is not available.  This allows removing some instances of isAvailable().

Implement some std::span interfaces in TrkVKalVrtFitter

See merge request atlas/athena!71315

Adam Edward Barton authored 10 months ago and Tadej Novak committed 10 months ago

Implement some std::span interfaces in TrkVKalVrtFitter

AthContainers: Updates for AtomicAccessor classes.

See merge request atlas/athena!71300

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

AthContainers: Updates for AtomicAccessor classes.

Add an allocator template parameter.
Proper handling of ConstAuxElement.

Update info message in MuonCalibrationConfig

See merge request atlas/athena!71319

Thomas Strebler authored 10 months ago and Tadej Novak committed 10 months ago

Update info message in MuonCalibrationConfig

MuonSelectorTools+ElectronPhotonSelectorTools: Use Accessor, etc instead of auxdata().

See merge request atlas/athena!71308

RootUtils: Delay setting root error handler.

See merge request atlas/athena!71292

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

RootUtils: Delay setting root error handler.

The ROOT error handler used by WithRootErrorHandler was being set when the
RootUtils library was loaded.  However, that may be too early; in particular,
the ATLAS RNTuple code sets a temporary error handler.

Change to setting the handler the first time WithRootErrorHandler gets called.

By the time we're called, there may be multiple threads running,
so it is in principle not safe to call SetErrorHandler.
However, there shouldn't be anything else in Athena calling it,
so in practice it should be ok.  As an extra check, we abort if the
handler we get back isn't what we set, indicating a potential race.

See ATLASRECTS-7967.

FPGATrackSimBankGen: Fix property initialization.

See merge request atlas/athena!71304

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

FPGATrackSimBankGen: Fix property initialization.

Fix typo in initialization of Gaudi property.

FPGATrackSimHough: Fix signed/unsigned comparison warnings.

See merge request atlas/athena!71302

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

FPGATrackSimHough: Fix signed/unsigned comparison warnings.

Fix signed/unsigned comparison warnings for Gaudi properties.

PyDumper: Support evgen files.

See merge request atlas/athena!71293

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

PyDumper: Support evgen files.

Support for dumping evgen files: we should't try to set up the geometry
in this case.

JetSubStructureMomentTools+JetCalibTools+JetMomentTools: Use Accessor, etc instead of auxdata().

See merge request atlas/athena!71307

FPGATrackSimSGInput: Fix cppcheck warnings.

See merge request atlas/athena!71305

FPGATrackSimMaps: Fix cppcheck warnings.

See merge request atlas/athena!71311

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

FPGATrackSimMaps: Fix cppcheck warnings.

Out-of-bounds array accesses.
Redundant map lookup.
Copying values in range-for.

FPGATrackSimAlgorithms: Fix cppcheck 2.14 warnings.

See merge request atlas/athena!71310

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

FPGATrackSimAlgorithms: Fix cppcheck 2.14 warnings.

Copying values in range-for.
Potential use of invalidated iterators.
Prefer range-for.
sprintf format/argument match.  sprintf buffer size.
Pass objects by const reference, not by value.
Prefer returning const references to members rather than copies.

FPGATrackSimBanks: Fix cppcheck 2.14 warnings.

See merge request atlas/athena!71309

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

FPGATrackSimBanks: Fix cppcheck 2.14 warnings.

Delete copy/assignment from class that manages memory.
Unknown macro.
Prefer returning const references to members rather than copies.
Prefer to pass strings/containers by const reference rather than value.

CPAlgorithms: allow to configure muon minimum pT

See merge request atlas/athena!71294

Baptiste Ravina authored 10 months ago and Tadej Novak committed 10 months ago

CPAlgorithms: allow to configure muon minimum pT