Dan Guest authored 10 months ago and Johannes Elmsheuser committed 10 months ago

Remove GN2v00 by default

Frank Winklmeier authored 10 months ago and Johannes Elmsheuser committed 10 months ago

PyUtils: fix flake8-bugbear warnings

Fix warnings about property access with known name.

Frank Winklmeier authored 10 months ago and Johannes Elmsheuser committed 10 months ago

CaloClusterCorrection+CaloCondPhysAlgs: fix flake8-bugbear warnings

Replace `getattr` with regular attribute access.

Frank Winklmeier authored 10 months ago and Johannes Elmsheuser committed 10 months ago

PyJobTransforms+SimuJobTransforms: fix flake8-bugbear warnings

Johannes Junggeburth authored 10 months ago and Johannes Elmsheuser committed 10 months ago

That's going to be interesting

Make the gasGap position public

GeoUtil tool

Why is the BMS gasgap off

Blub

Electric fields  are inclined for phi panels

The LHC is a testbam

Try to patch invalid strips

Madness is coming along with this code

Apply 1 suggestion(s) to 1 file(s)

Write python macro to compare digitization

Chasing differences in the phi geometry

Digit variables

Why did the phi hits drop

Fix local positions

Blub

Fix the digit association... Finally

Comment

Marilena Bandieramonte authored 10 months ago and Ahmed Tarek committed 10 months ago

Keep the energy loss fluctuation process ON for mc23e

Frank Winklmeier authored 10 months ago and Duc Ta committed 10 months ago

PyJobTransforms: remove support for CARunner

CA-based pkl files can be run directly with athena and the CARunner is
deprecated.

The only remaining use-cases are:
  - `EvgenJobTransforms`
  - the standalone command line utilities `find_data.py`,
    `find_library.py` and `find_python_modules.py`

Grigori Rybkin authored 10 months ago and Walter Lampl committed 10 months ago

PyUtils: Fix exception handling in MetaReader.py

Tools/PyUtils/python/MetaReader.py: remove redundant piece of code, simplify

John Derek Chapman authored 10 months ago and Duc Ta committed 10 months ago

Add Campaigns.MC23HeavyIons2023 and Campaigns.MC23HeavyIons2023NoPileUp
(and legacy config equivalents for RDOtoRDOTrigger step)

This tool has very limited usage. The log file generation can be activated
by using the relevant flag, if needed

Maciej Pawel Szymanski authored 11 months ago and Walter Lampl committed 11 months ago

Fix reading metadata from event-less BS files

Delete all mostly broken and unused `scripts/` and `python` modules.
Only the ART test definitions remain.

Marilena Bandieramonte authored 11 months ago and Duc Ta committed 11 months ago

Add the energy loss fluctuation off to the G4Optimizations for mc23e

Hopefully, the last stage of the campaign

Grigori Rybkin authored 11 months ago and Frank Winklmeier committed 11 months ago

PyUtils: Extract number of entries from EventStreamInfo if available

Tools/PyUtils/python/MetaReader.py: fix extracting of number of entries,
re-factor extracting of number of entries from DataHeader into a function

The calls to AthFile functions substitued by the calls to
read_metadata() from PyUtils.MetaReader and to file_name from PyUtils.PoolFile

Johannes Elmsheuser authored 11 months ago and Frank Winklmeier committed 11 months ago

TrfTestsART: Choose GPU with lowest utilization in test_trf_athexcuda.sh

Luca Martinelli authored 11 months ago and Frank Winklmeier committed 11 months ago

MuonCalibTool: making calibMode configurable and change default value

PyUtils: remove installation of non-existent files

Under the hood both of these utuilities execute job options scripts
that rely on the scripts which no longer exist in the Athena main:
- `RecExCond/RecExCommon_flags.py`
- `RecExCommon/RecExCommon_topOptions.py`

Johannes Elmsheuser authored 11 months ago and Frank Winklmeier committed 11 months ago

Switch off output comparision with reference file to avoid Intel vs. AMD float variable differences in FTAG

Grigori Rybkin authored 11 months ago and Frank Winklmeier committed 11 months ago

PyUtils: Enhance checkxAOD output

Tools/PyUtils/python/PoolFile.py: attempt to determine type name for branches of fundamental type

John Derek Chapman authored 11 months ago and Frank Winklmeier committed 11 months ago

SiHitCollectionCnv_p3_test: Activate comparisons of HepMcParticleLink members in SiHitCollection_p3 objects

Removed unused functions:
* _guess_file_type() in AthFile
* extract_stream_names() in PoolFile.py

Gradual removal of the dependency on AthFile from PoolFile.py

Marilena Bandieramonte authored 11 months ago and Ahmed Tarek committed 11 months ago

Add missing import for mc23e campaign

The extract_items() function from PoolFile.py is used by the checkSG utility.
The dependency on AthFile was replaced by the dependency on the FilePeekerTool.
The change required copying of a few auxilliary functions from AthFile/impl.py
into PoolFile.py. For the time being this results in code duplication. The
duplication will be fixed when we drop AthFile from the Athena main

Tadej Novak authored 11 months ago and Adam Edward Barton committed 11 months ago

AMITagHelperConfig: Do not write out metadata if no AMI tag present

Maciej Pawel Szymanski authored 11 months ago and Adam Edward Barton committed 11 months ago

MetaReader: fix flake8-bugbear warnings