- May 13, 2024
-
-
Add phi extension to Phase-2 Muon pattern recognition and clean up / document existing steps
-
MuonReadoutGeometryR4: Speed up MdtTubeLayer::getTubeNode(). This was using getChildVol. However, that keeps track of the transform to each child, even though that is not actually used. This is slow, especially in debug builds where Eigen operations tend to be expensive. Instead, use GeoVisitVolumes to iterate over children without calculating the transforms.
-
- May 12, 2024
-
-
MuonGeoModelTestR4: cmake fix Missing find_package for ROOT.
-
- May 10, 2024
-
-
Made all binaries that depend on LTO, use LTO themselves as well. Also, moved MuonSensitiveDetectorsR4 into AtlasGeant4.
-
Cosmetic changes to sTGC monitoring plots v2
-
- May 09, 2024
-
-
MuonEvenTPCnv - Fix unit test
-
- May 08, 2024
-
-
p3 version of TP convertors for HepMC particle link v3
-
MMReadoutElement - Clean up initialization stage
-
MuonGeoModelTestR4: Fix cppcheck warnings. Use string::starts_with rather than string::find.
-
MuonReadoutGeometryR4: Speed up handling of tube transforms. Calling toTubeFrame is expensive, since it needs to walk over all children until it gets to the desired value. Hence, calling toTubeFrame from within a loop over tubes is an N^2 operation. Further, MdtReadoutElement::initElement() was calling toTubeFrame multiple times for each tube. This is especially painful in a debug build, where Eigen matrix operations are very slow. Speed up by using GeoVolumeCursor to change from the nested O(N^2) iteration to a single O(N) iteration, and only evaluate the transform once per tube. Also fix a logic error the prevented the layer-to-layer pitch test from executing.
-
Muon R4 - Add infrastructure to digitize BI-RPC hits
-
Improving hashing for BIL with adding the zIndex and changing multidimensional array to a std_unordered map with some input from Johannes
-
- May 07, 2024
-
-
sTgcReadoutGeometry - Minor clean-up of the factory methods & msg streams
-
-
Oliver But authored
-
Oliver But authored
-
Oliver But authored
-
Oliver But authored
-
Oliver But authored
-
Try to use C++20 starts_with
-
Cosmetic changes to sTGC monitoring plots
-
Tracking move to std::span from CxxUtils::span
-
- May 06, 2024
-
-
MuonR4 - Fix failing unit tests
-
That's going to be interesting Make the gasGap position public GeoUtil tool Why is the BMS gasgap off Blub Electric fields are inclined for phi panels The LHC is a testbam Try to patch invalid strips Madness is coming along with this code Apply 1 suggestion(s) to 1 file(s) Write python macro to compare digitization Chasing differences in the phi geometry Digit variables Why did the phi hits drop Fix local positions Blub Fix the digit association... Finally Comment
-
PrepData R4 - Add BI RpcStrip container class
-
- May 04, 2024
-
-
MuonGeoModelTestR4: Fix placement of using directives. Don't put using directives before #include.
-
MuonTrackFinderTools: Avoid FPE with clang. In MuonTrackToSegmentTool::convert, tell clang to compile assuming that FP operations can raise exceptions. Fixes test failure seen in MuonConfig in the clang build.
-
- May 03, 2024
-
-
MuonSimEvent: Update SimHit classes to use position-based HepMcParticleLink constructor internally
-
- May 02, 2024
-
-
MuonReadoutGeometryR4: Speed up tube layer sorting. In the comparison function for MdtTubeLayer, don't bother calling the underlying comparison functions if the objects being compared are identical. GeoPhysValSorter, in particular, is expensive to call. This speeds things up considerably, especially in the debug build.
-
Frank Winklmeier authoredB005: Using .strip() with multi-character strings
-
- Apr 30, 2024
-
-
Add CMake option to enable LTO for AtlasGeant4 Use of LTO in Athena builds is not currently possible if the GCC checker plugins are in use. These are not yet LTO-aware, leading to build errors. Disabling these globally or per-LTO-using-package is not feasible as it could lead to the introduction of bad code. Whilst the plugins are made LTO-aware, introduce CMake option in Athena and AthSimulation for enabling LTO builds of the AtlasGeant4 "big" library. Set to OFF by default so that "normal" builds are unaffected. Builds wanting LTO can set the option to ON, but must also set ATLAS_USE_GCC_CHECKERS to OFF in this case.
-
Frank Winklmeier authored
-
scott snyder authored
Suppress bogus cppcheck missingReturn warnings.
-
Savanna Shaw authored
-
- Apr 29, 2024
-
-
Walter Lampl authoredThis reverts commit 9b36ad1f, reversing changes made to 4d2926b2.
-
Add CMake option to enable LTO for AtlasGeant4 Use of LTO in Athena builds is not currently possible if the GCC checker plugins are in use. These are not yet LTO-aware, leading to build errors. Disabling these globally or per-LTO-using-package is not feasible as it could lead to the introduction of bad code. Whilst the plugins are made LTO-aware, introduce CMake option in Athena and AthSimulation for enabling LTO builds of the AtlasGeant4 "big" library. Set to OFF by default so that "normal" builds are unaffected. Builds wanting LTO can set the option to ON, but must also set ATLAS_USE_GCC_CHECKERS to OFF in this case.
-
Jiří Mašík authored
-
- Apr 25, 2024
-
-
MuonR4 geometry - Fix crashes when running with multiple threads
-
RpcSensitiveDetectors - Remove isGeoModel property
-
MuonSpacePoint: Fix eigen alias problem. Fix a problem with aliasing eigen objects. Fixes test failure seen in MuonHitCsvDump in the debug build.
-
